Commit:     d90bf5a976793edfa88d3bb2393f0231eb8ce1e5
Parent:     66ba886254edbbd9442d30f1eef6f6fb0145027d
Author:     Eric Dumazet <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 14 16:14:05 2007 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Wed Nov 14 16:14:05 2007 -0800

    [NET]: rt_check_expire() can take a long time, add a cond_resched()
    On commit 39c90ece7565f5c47110c2fa77409d7a9478bd5b:
        [IPV4]: Convert rt_check_expire() from softirq processing to workqueue.
    we converted rt_check_expire() from softirq to workqueue, allowing the
    function to perform all work it was supposed to do.
    When the IP route cache is big, rt_check_expire() can take a long time
    to run.  (default settings : 20% of the hash table is scanned at each
    Adding cond_resched() helps giving cpu to higher priority tasks if
    Using a "if (need_resched())" test before calling "cond_resched();" is
    necessary to avoid spending too much time doing the resched check.
    (My tests gave a time reduction from 88 ms to 25 ms per
    rt_check_expire() run on my i686 test machine)
    Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/ipv4/route.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 4565183..1bff9ed 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -578,6 +578,9 @@ static void rt_check_expire(struct work_struct *work)
                i = (i + 1) & rt_hash_mask;
                rthp = &rt_hash_table[i].chain;
+               if (need_resched())
+                       cond_resched();
                if (*rthp == NULL)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to