Commit:     e383d19e90cfbbf8e00512d44194ce175b3f60a2
Parent:     9a7666494bac60b99d2bd7d904bd22e8c9b1e3f7
Author:     Jack Morgenstein <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 14 16:33:27 2007 +0200
Committer:  Roland Dreier <[EMAIL PROTECTED]>
CommitDate: Wed Nov 14 08:20:03 2007 -0800

    mlx4_core: Fix thinko in QP destroy (incorrect bitmap_free)
    Fix thinko in commit eaf559bf ("mlx4_core: Don't free special QPs in
    QP number bitmap").  The old commit had the logic exactly backwards
    and ended up freeing *only* special QPs, which not only left the
    original bug in place but also introduced the problem that the QP
    number bitmap would get full after a while.
    Found by Dotan Barak of Mellanox.
    Signed-off-by: Jack Morgenstein <[EMAIL PROTECTED]>
    Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
 drivers/net/mlx4/qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/qp.c b/drivers/net/mlx4/qp.c
index cc4b1be..42b4763 100644
--- a/drivers/net/mlx4/qp.c
+++ b/drivers/net/mlx4/qp.c
@@ -240,7 +240,7 @@ void mlx4_qp_free(struct mlx4_dev *dev, struct mlx4_qp *qp)
        mlx4_table_put(dev, &qp_table->auxc_table, qp->qpn);
        mlx4_table_put(dev, &qp_table->qp_table, qp->qpn);
-       if (qp->qpn < dev->caps.sqp_start + 8)
+       if (qp->qpn >= dev->caps.sqp_start + 8)
                mlx4_bitmap_free(&qp_table->bitmap, qp->qpn);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to