Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=94bc9a7bd97efdda4dfbe61d0df32ce19d41c0a9
Commit:     94bc9a7bd97efdda4dfbe61d0df32ce19d41c0a9
Parent:     ce96b5ac742801718ae86d2adf0500c5abef3782
Author:     Dmitry Adamushko <[EMAIL PROTECTED]>
AuthorDate: Thu Nov 15 20:57:40 2007 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Thu Nov 15 20:57:40 2007 +0100

    sched: remove activate_idle_task()
    
    cpu_down() code is ok wrt sched_idle_next() placing the 'idle' task not
    at the beginning of the queue.
    
    So get rid of activate_idle_task() and make use of activate_task() instead.
    It is the same as activate_task(), except for the update_rq_clock(rq) call
    that is redundant.
    
    Code size goes down:
    
       text    data     bss     dec     hex filename
      47853    3934     336   52123    cb9b sched.o.before
      47828    3934     336   52098    cb82 sched.o.after
    
    Signed-off-by: Dmitry Adamushko <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
 kernel/sched.c |   22 ++++------------------
 1 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index db1f71e..cc8cb6f 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5282,23 +5282,9 @@ static void migrate_live_tasks(int src_cpu)
 }
 
 /*
- * activate_idle_task - move idle task to the _front_ of runqueue.
- */
-static void activate_idle_task(struct task_struct *p, struct rq *rq)
-{
-       update_rq_clock(rq);
-
-       if (p->state == TASK_UNINTERRUPTIBLE)
-               rq->nr_uninterruptible--;
-
-       enqueue_task(rq, p, 0);
-       inc_nr_running(p, rq);
-}
-
-/*
  * Schedules idle task to be the next runnable task on current CPU.
- * It does so by boosting its priority to highest possible and adding it to
- * the _front_ of the runqueue. Used by CPU offline code.
+ * It does so by boosting its priority to highest possible.
+ * Used by CPU offline code.
  */
 void sched_idle_next(void)
 {
@@ -5318,8 +5304,8 @@ void sched_idle_next(void)
 
        __setscheduler(rq, p, SCHED_FIFO, MAX_RT_PRIO-1);
 
-       /* Add idle task to the _front_ of its priority queue: */
-       activate_idle_task(p, rq);
+       update_rq_clock(rq);
+       activate_task(rq, p, 0);
 
        spin_unlock_irqrestore(&rq->lock, flags);
 }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to