Commit:     1401b53acc0328d96bacb2a3393d2852699df96b
Parent:     7749c902592f610dc448830210174ab922f54be9
Author:     Jack Morgenstein <[EMAIL PROTECTED]>
AuthorDate: Mon Nov 26 10:41:19 2007 +0200
Committer:  Roland Dreier <[EMAIL PROTECTED]>
CommitDate: Tue Nov 27 15:40:10 2007 -0800

    IPoIB: Fix oops if xmit is called when priv->broadcast is NULL
    If a port goes down, ipoib_ib_dev_down() is invoked -- which flushes
    the mcasts (clearing priv->broadcast) and clearing the path record
    cache.  If ipoib_start_xmit() is then invoked (before the broadcast
    group is rejoined), a kernel oops results from attempting to access
    priv->broadcast, which is still unset.
    Returning NULL from path_rec_create() if priv->broadcast is NULL is a
    harmless way of bypassing the problem -- the offending packet is
    simply discarded "without prejudice."
    Signed-off-by: Jack Morgenstein <[EMAIL PROTECTED]>
    Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
 drivers/infiniband/ulp/ipoib/ipoib_main.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c 
index a03a65e..c9f6077 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -460,6 +460,9 @@ static struct ipoib_path *path_rec_create(struct net_device 
*dev, void *gid)
        struct ipoib_dev_priv *priv = netdev_priv(dev);
        struct ipoib_path *path;
+       if (!priv->broadcast)
+               return NULL;
        path = kzalloc(sizeof *path, GFP_ATOMIC);
        if (!path)
                return NULL;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to