Commit:     3f86f14c0fc9fdb0984e64209df2f47895a07151
Parent:     068f4070868c801c7d7aa1ae1193c1c854193545
Author:     David Brownell <[EMAIL PROTECTED]>
AuthorDate: Tue Dec 4 23:45:10 2007 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Wed Dec 5 09:21:18 2007 -0800

    spi: at25 driver is for EEPROM not FLASH
    Add comment to at25 driver that it's for EEPROM chips, not FLASH
    chips ... the AT25 series has both types of chip, and sometimes
    they're even pin-compatible.  The command sets are different, as
    is the treatment of erasure.  (FLASH needs explicit erasure, but
    with EEPROM it's implicit.)  Note that all vendors seem to have
    this same confusion in their *25* series SPI memory parts.
    Signed-off-by: David Brownell <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 drivers/spi/at25.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/at25.c b/drivers/spi/at25.c
index e007833..290dbe9 100644
--- a/drivers/spi/at25.c
+++ b/drivers/spi/at25.c
@@ -21,6 +21,13 @@
 #include <linux/spi/eeprom.h>
+ * NOTE: this is an *EEPROM* driver.  The vagaries of product naming
+ * mean that some AT25 products are EEPROMs, and others are FLASH.
+ * Handle FLASH chips with the drivers/mtd/devices/m25p80.c driver,
+ * not this one!
+ */
 struct at25_data {
        struct spi_device       *spi;
        struct mutex            lock;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to