Commit:     968530643a0685caced9dfd6f72f20d5e7bc8fbb
Parent:     8df4538e21f7313a29fa6c5af78c08a135d44738
Author:     Benjamin Herrenschmidt <[EMAIL PROTECTED]>
AuthorDate: Wed Dec 5 11:14:27 2007 +1100
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Fri Dec 7 15:09:05 2007 -0500

    ibm_newemac: Fix ZMII refcounting bug
    When using ZMII for MDIO only (such as 440GX with RGMII for data and ZMII 
    MDIO), the ZMII code would fail to properly refcount, thus triggering a
    Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
    Acked-by: Stefan Roese <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/net/ibm_newemac/zmii.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ibm_newemac/zmii.c b/drivers/net/ibm_newemac/zmii.c
index 2219ec2..0f8cfbc 100644
--- a/drivers/net/ibm_newemac/zmii.c
+++ b/drivers/net/ibm_newemac/zmii.c
@@ -83,12 +83,14 @@ int __devinit zmii_attach(struct of_device *ofdev, int 
input, int *mode)
        ZMII_DBG(dev, "init(%d, %d)" NL, input, *mode);
-       if (!zmii_valid_mode(*mode))
+       if (!zmii_valid_mode(*mode)) {
                /* Probably an EMAC connected to RGMII,
                 * but it still may need ZMII for MDIO so
                 * we don't fail here.
+               dev->users++;
                return 0;
+       }
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to