Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4037500ebcfd172a15aed40caa847c52e9906712
Commit:     4037500ebcfd172a15aed40caa847c52e9906712
Parent:     d20e47e153dcfddca5a066ff0f8da2d1104d08ea
Author:     Ralf Baechle <[EMAIL PROTECTED]>
AuthorDate: Fri Dec 14 00:05:34 2007 +0000
Committer:  Ralf Baechle <[EMAIL PROTECTED]>
CommitDate: Fri Dec 14 17:34:30 2007 +0000

    [MIPS] time: Delete weak definition of plat_time_init() due to gcc bug.
    
    Frank Rowand <[EMAIL PROTECTED]> reports:
    
    > In linux-2.6.24-rc4 the Toshiba RBTX4927 hangs on boot.
    >
    > The cause is that plat_time_init() from arch/mips/tx4927/common/
    > tx4927_setup.c does not override the __weak plat_time_init() from
    > arch/mips/kernel/time.c.  This is due to a compiler bug in gcc 4.1.1.  The
    > bug is reported to not exist in earlier versions of gcc, and to be fixed 
in
    > 4.1.2.  The problem is that the __weak plat_time_init() is empty and thus
    > gets optimized out of existence (thus the linker is never given the option
    > to replace the __weak function).
    
    [ He meant the call to plat_time_init() from time_init() gets optimized 
away ]
    
    > For more info on the gcc bug see
    >
    >    http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781
    >
    > The attached patch is one workaround.  Another possible workaround
    
    [ His patch adds -fno-unit-at-a-time for time.c ]
    
    > would be to change the __weak plat_time_init() to be a non-empty
    > function.
    
    The __weak definition of plat_time_init was only ever meant to be a
    migration helper to keep platforms that don't have a plat_time_init
    compiling.  A few greps says that all platforms now supply their own
    plat_time_init() so the weak definition is no longer needed.  So I
    instead delete it.
    
    Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
---
 arch/mips/kernel/time.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/mips/kernel/time.c b/arch/mips/kernel/time.c
index 5207542..1ecfbb7 100644
--- a/arch/mips/kernel/time.c
+++ b/arch/mips/kernel/time.c
@@ -109,10 +109,6 @@ void __cpuinit clockevent_set_clock(struct 
clock_event_device *cd,
        cd->mult = (u32) temp;
 }
 
-void __init __weak plat_time_init(void)
-{
-}
-
 /*
  * This function exists in order to cause an error due to a duplicate
  * definition if platform code should have its own implementation.  The hook
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to