Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=813820b9b9adb98d4ad3cd7434eb662b0fc15684
Commit:     813820b9b9adb98d4ad3cd7434eb662b0fc15684
Parent:     14c9d9b03bb8ec63c77aebddea9a6f730f1b62d5
Author:     Al Viro <[EMAIL PROTECTED]>
AuthorDate: Sun Dec 9 17:00:54 2007 +0000
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Fri Dec 14 15:26:04 2007 -0500

    starfire VLAN fix
    
    Recognized VLAN ids are set via writew(), should go in host-endian.
    That's a long-standing bug, BTW - see http://lkml.org/lkml/2004/2/27/180
    for example.  What happens is that card gets VLAN id table populated by
    byteswapped values on little-endian boxen (so 257 works as expected, 256
    and 258 do not, etc.).  Bug is easily reproduced, patch fixes it.
    
    Signed-off-by: Al Viro <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
 drivers/net/starfire.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c
index bcc430b..6e00dc8 100644
--- a/drivers/net/starfire.c
+++ b/drivers/net/starfire.c
@@ -1742,7 +1742,7 @@ static void set_rx_mode(struct net_device *dev)
                        if (vlan_group_get_device(np->vlgrp, i)) {
                                if (vlan_count >= 32)
                                        break;
-                               writew(cpu_to_be16(i), filter_addr);
+                               writew(i, filter_addr);
                                filter_addr += 16;
                                vlan_count++;
                        }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to