Commit:     d172f4ef31bec924c6ebcb242c9d7d290811e1e5
Parent:     e5f114e97d6e4833e90ca408af9eb1e7a3262b5e
Author:     Greg Kroah-Hartman <[EMAIL PROTECTED]>
AuthorDate: Sat Dec 22 21:18:25 2007 -0800
Committer:  Greg Kroah-Hartman <[EMAIL PROTECTED]>
CommitDate: Sat Dec 22 23:09:05 2007 -0800

    Modules: fix memory leak of module names
    Due to the change in kobject name handling, the module kobject needs to
    have a null release function to ensure that the name it previously set
    will be properly cleaned up.
    All of this wierdness goes away in 2.6.25 with the rework of the kobject
    name and cleanup logic, but this is required for 2.6.24.
    Thanks to Alexey Dobriyan for finding the problem, and to Kay Sievers
    for pointing out the simple way to fix it after I tried many complex
    Cc: Alexey Dobriyan <[EMAIL PROTECTED]>
    Cc: Kay Sievers <[EMAIL PROTECTED]>
    Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
 kernel/params.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 2a4c514..7686417 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -697,8 +697,18 @@ static struct kset_uevent_ops module_uevent_ops = {
 decl_subsys(module, &module_ktype, &module_uevent_ops);
 int module_sysfs_initialized;
+static void module_release(struct kobject *kobj)
+       /*
+        * Stupid empty release function to allow the memory for the kobject to
+        * be properly cleaned up.  This will not need to be present for 2.6.25
+        * with the upcoming kobject core rework.
+        */
 static struct kobj_type module_ktype = {
        .sysfs_ops =    &module_sysfs_ops,
+       .release =      module_release,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to