Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=134d99e302618eeb102c2a5be1f9e98696288bdd Commit: 134d99e302618eeb102c2a5be1f9e98696288bdd Parent: 44344b2a85f03326c7047a8c861b0c625c674839 Author: Li Zefan <[EMAIL PROTECTED]> AuthorDate: Fri Jan 4 01:52:02 2008 -0800 Committer: David S. Miller <[EMAIL PROTECTED]> CommitDate: Fri Jan 4 03:55:37 2008 -0800
[CONNECTOR]: Return proper error code in cn_call_callback() Error code should be set to EINVAL instead of ENODEV if !queue_work(). There's another call of queue_work() which may set err to EINVAL. Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- drivers/connector/connector.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index 6883fcb..bf9716b 100644 --- a/drivers/connector/connector.c +++ b/drivers/connector/connector.c @@ -145,6 +145,8 @@ static int cn_call_callback(struct cn_msg *msg, void (*destruct_data)(void *), v if (queue_work(dev->cbdev->cn_queue, &__cbq->work)) err = 0; + else + err = -EINVAL; } else { struct cn_callback_data *d; - To unsubscribe from this list: send the line "unsubscribe git-commits-head" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html