Commit:     c2e14f11120bbef0c883e795da8180b58f3cddae
Parent:     7293fa8fb74f17077a2ac7ccd5b58ae3225317d0
Author:     Tejun Heo <[EMAIL PROTECTED]>
AuthorDate: Sun Jan 13 14:04:16 2008 +0900
Committer:  Jeff Garzik <[EMAIL PROTECTED]>
CommitDate: Mon Jan 14 21:11:02 2008 -0500

    sata_sil24: freeze on non-dev errors reported via CERR
    CERR reports errors detected during executing a command.  This doesn't
    mean the error is tied to the command and can be recovered by just
    issuing it again.  Many of the errors are fatal port-wide connditions
    including HSM violation, host bus error and ATA bus error and require
    freezing and port reset.
    The freezing part wasn't implemented previously.  This used to be okay
    because port resets were scheduled anyway and EH eventually resets and
    recovers the port.  With PMP support added, this is no longer true.
    The error condition and recover actions are attributed to the fan-out
    port and the host port condition isn't properly recovered leading to
    EH failures.
    This patch makes CERR errors which require resets to freeze the port.
    This will force host port reset and proper recovery.
    Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
    Cc: Andrew Ryder <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/ata/sata_sil24.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index d9c8b32..864c1c1 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -1094,10 +1094,13 @@ static void sil24_error_intr(struct ata_port *ap)
                if (ci && ci->desc) {
                        err_mask |= ci->err_mask;
                        action |= ci->action;
+                       if (action & ATA_EH_RESET_MASK)
+                               freeze = 1;
                        ata_ehi_push_desc(ehi, "%s", ci->desc);
                } else {
                        err_mask |= AC_ERR_OTHER;
                        action |= ATA_EH_SOFTRESET;
+                       freeze = 1;
                        ata_ehi_push_desc(ehi, "unknown command error %d",
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to