Commit:     b3652b2dc5ec6ccd946ae9136b30c6babb81305a
Parent:     632041f306707df94110441f55b1458ebeb096db
Author:     Pavel Emelyanov <[EMAIL PROTECTED]>
AuthorDate: Fri Jan 18 03:27:12 2008 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Sun Jan 20 20:31:36 2008 -0800

    [IPV6]: Mischecked tw match in __inet6_check_established.
    When looking for a conflicting connection the !sk->sk_bound_dev_if
    check is performed only for live sockets, but not for timewait-ed.
    This is not the case for ipv4, for __inet6_lookup_established in
    both ipv4 and ipv6 and for other places that check for tw-s.
    Was this missed accidentally? If so, then this patch fixes it and
    besides makes use if the dif variable declared in the function.
    Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/ipv6/inet6_hashtables.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/inet6_hashtables.c b/net/ipv6/inet6_hashtables.c
index adc73ad..0765d8b 100644
--- a/net/ipv6/inet6_hashtables.c
+++ b/net/ipv6/inet6_hashtables.c
@@ -193,7 +193,7 @@ static int __inet6_check_established(struct 
inet_timewait_death_row *death_row,
                   sk2->sk_family              == PF_INET6       &&
                   ipv6_addr_equal(&tw6->tw_v6_daddr, saddr)     &&
                   ipv6_addr_equal(&tw6->tw_v6_rcv_saddr, daddr) &&
-                  sk2->sk_bound_dev_if == sk->sk_bound_dev_if) {
+                  (!sk2->sk_bound_dev_if || sk2->sk_bound_dev_if == dif)) {
                        if (twsk_unique(sk, sk2, twp))
                                goto unique;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to