Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3828ff457a694f97f88f6978bea428199df0a690
Commit:     3828ff457a694f97f88f6978bea428199df0a690
Parent:     8d8293cfb38b042835eeded7c1d90f75ca243e87
Author:     Ralph Campbell <[EMAIL PROTECTED]>
AuthorDate: Tue Oct 23 15:04:15 2007 -0700
Committer:  Roland Dreier <[EMAIL PROTECTED]>
CommitDate: Fri Jan 25 14:15:25 2008 -0800

    IB/mad: Remove redundant NULL pointer check in ib_mad_recv_done_handler()
    
    In ib_mad_recv_done_handler(), the response pointer is checked for
    NULL after allocating it.  It is then checked again in the local
    process_mad() path but there is no possibility of it changing in
    between.
    
    Signed-off-by: Ralph Campbell <[EMAIL PROTECTED]>
    Acked-by: Hal Rosenstock <[EMAIL PROTECTED]>
    Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
---
 drivers/infiniband/core/mad.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 6f42877..f82900d 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -1931,15 +1931,6 @@ local:
        if (port_priv->device->process_mad) {
                int ret;
 
-               if (!response) {
-                       printk(KERN_ERR PFX "No memory for response MAD\n");
-                       /*
-                        * Is it better to assume that
-                        * it wouldn't be processed ?
-                        */
-                       goto out;
-               }
-
                ret = port_priv->device->process_mad(port_priv->device, 0,
                                                     port_priv->port_num,
                                                     wc, &recv->grh,
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to