Commit:     ed2b91701d97047fa9970645e43d5e551e261adb
Parent:     e6ab15827eec0bc4444421f7ccf0223de321c708
Author:     Steve French <[EMAIL PROTECTED]>
AuthorDate: Sun Jan 20 00:30:29 2008 +0000
Committer:  Steve French <[EMAIL PROTECTED]>
CommitDate: Sun Jan 20 00:30:29 2008 +0000

    [CIFS] Do not log path names in lookup errors
    Andi Kleen noticed that we were logging access denied errors (which is
    noisy in the dmesg log, and not needed to be logged) and that we were
    logging path names on that an other errors (e.g. EIO) which we should
    not be doing.
    CC: Andi Kleen <[EMAIL PROTECTED]>
    Signed-off-by: Steve French <[EMAIL PROTECTED]>
 fs/cifs/dir.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 37dc97a..699ec11 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -517,12 +517,10 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry 
                d_add(direntry, NULL);
        /*      if it was once a directory (but how can we tell?) we could do
                shrink_dcache_parent(direntry); */
-       } else {
-               cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s",
-                          rc, full_path));
-               /* BB special case check for Access Denied - watch security
-               exposure of returning dir info implicitly via different rc
-               if file exists or not but no access BB */
+       } else if (rc != -EACCES) {
+               cERROR(1, ("Unexpected lookup error %d", rc));
+               /* We special case check for Access Denied - since that
+               is a common return code */
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to