Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fd8e7af8d0fd3febc87607214d5dd545089edc71
Commit:     fd8e7af8d0fd3febc87607214d5dd545089edc71
Parent:     7b5dea12346f98b0624e00ef585246bfec8b0959
Author:     Russell King <[EMAIL PROTECTED]>
AuthorDate: Wed Jan 23 12:33:31 2008 +0000
Committer:  Russell King <[EMAIL PROTECTED]>
CommitDate: Sat Jan 26 15:07:57 2008 +0000

    [ARM] pxa: Avoid fiddling with CKEN register on suspend
    
    The PXA manuals indicate that when in standby or sleep modes, clocks to
    peripherals are shut off by the processor itself.  Eg:
    
    PXA270 standby: "In standby mode, all clocks are disabled except those
     for the power manager and the RTC."
    
    PXA270 sleep: "In sleep mode, all clocks are disabled to the processor
     and to all peripherals except the RTC."
    
    PXA255 sleep: "In Sleep Mode, all processor and peripheral clocks are
     disabled, except the RTC."
    
    Therefore, it should be safe to leave the clock enable register alone
    prior to entering low power modes for these SoCs.
    
    Signed-off-by: Russell King <[EMAIL PROTECTED]>
---
 arch/arm/mach-pxa/pxa25x.c |    2 --
 arch/arm/mach-pxa/pxa27x.c |    6 ------
 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-pxa/pxa25x.c b/arch/arm/mach-pxa/pxa25x.c
index 962cfbb..73a5f06 100644
--- a/arch/arm/mach-pxa/pxa25x.c
+++ b/arch/arm/mach-pxa/pxa25x.c
@@ -216,8 +216,6 @@ static void pxa25x_cpu_pm_restore(unsigned long *sleep_save)
 
 static void pxa25x_cpu_pm_enter(suspend_state_t state)
 {
-       CKEN = 0;
-
        switch (state) {
        case PM_SUSPEND_MEM:
                /* set resume return address */
diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
index f33c9d7..db0c4c6 100644
--- a/arch/arm/mach-pxa/pxa27x.c
+++ b/arch/arm/mach-pxa/pxa27x.c
@@ -265,12 +265,6 @@ void pxa27x_cpu_pm_enter(suspend_state_t state)
 {
        extern void pxa_cpu_standby(void);
 
-       if (state == PM_SUSPEND_STANDBY)
-               CKEN = (1 << CKEN_MEMC) | (1 << CKEN_OSTIMER) |
-                       (1 << CKEN_LCD) | (1 << CKEN_PWM0);
-       else
-               CKEN = (1 << CKEN_MEMC) | (1 << CKEN_OSTIMER);
-
        /* ensure voltage-change sequencer not initiated, which hangs */
        PCFR &= ~PCFR_FVC;
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to