Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a63b22bb5bb58d7a1d1b38aeac9a55c51565131c
Commit:     a63b22bb5bb58d7a1d1b38aeac9a55c51565131c
Parent:     aa21c004f80bdf943736c62dccf0c0398d7824f3
Author:     David Woodhouse <[EMAIL PROTECTED]>
AuthorDate: Sat Dec 8 20:56:44 2007 +0000
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Jan 28 15:06:20 2008 -0800

    libertas: use lbs_host_to_card_done() in lbs_tx_timeout()
    
    Also attempt some locking in lbs_host_to_card_done()
    
    Signed-off-by: David Woodhouse <[EMAIL PROTECTED]>
    Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
 drivers/net/wireless/libertas/main.c |   40 ++++++++++++++-------------------
 1 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/drivers/net/wireless/libertas/main.c 
b/drivers/net/wireless/libertas/main.c
index 243cdea..2ff5f1b 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -601,31 +601,24 @@ static void lbs_tx_timeout(struct net_device *dev)
 
        lbs_pr_err("tx watch dog timeout\n");
 
-       priv->dnld_sent = DNLD_RES_RECEIVED;
        dev->trans_start = jiffies;
 
        if (priv->currenttxskb) {
-               if (priv->monitormode != LBS_MONITOR_OFF) {
-                       /* If we are here, we have not received feedback from
-                          the previous packet.  Assume TX_FAIL and move on. */
-                       priv->eventcause = 0x01000000;
-                       lbs_send_tx_feedback(priv);
-               } else
-                       wake_up_interruptible(&priv->waitq);
-       } else if (dev == priv->dev) {
-               if (priv->connect_status == LBS_CONNECTED)
-                       netif_wake_queue(priv->dev);
-
-       } else if (dev == priv->mesh_dev) {
-               if (priv->mesh_connect_status == LBS_CONNECTED)
-                       netif_wake_queue(priv->mesh_dev);
+               priv->eventcause = 0x01000000;
+               lbs_send_tx_feedback(priv);
        }
+       /* XX: Shouldn't we also call into the hw-specific driver
+          to kick it somehow? */
+       lbs_host_to_card_done(priv);
 
        lbs_deb_leave(LBS_DEB_TX);
 }
 
 void lbs_host_to_card_done(struct lbs_private *priv)
 {
+       unsigned long flags;
+
+       spin_lock_irqsave(&priv->driver_lock, flags);
 
        priv->dnld_sent = DNLD_RES_RECEIVED;
 
@@ -634,15 +627,16 @@ void lbs_host_to_card_done(struct lbs_private *priv)
                wake_up_interruptible(&priv->waitq);
 
        /* Don't wake netif queues if we're in monitor mode and
-          a TX packet is already pending. */
-       if (priv->currenttxskb)
-               return;
-
-       if (priv->dev && priv->connect_status == LBS_CONNECTED)
-               netif_wake_queue(priv->dev);
+          a TX packet is already pending, or if there are commands
+          queued to be sent. */
+       if (!priv->currenttxskb && list_empty(&priv->cmdpendingq)) {
+               if (priv->dev && priv->connect_status == LBS_CONNECTED)
+                       netif_wake_queue(priv->dev);
 
-       if (priv->mesh_dev && priv->mesh_connect_status == LBS_CONNECTED)
-               netif_wake_queue(priv->mesh_dev);
+               if (priv->mesh_dev && priv->mesh_connect_status == 
LBS_CONNECTED)
+                       netif_wake_queue(priv->mesh_dev);
+       }
+       spin_unlock_irqrestore(&priv->driver_lock, flags);
 }
 EXPORT_SYMBOL_GPL(lbs_host_to_card_done);
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to