Commit:     8304b633c5e8c9ba34d3cc7f24f52434d3a3b93b
Parent:     5d8949448b68b3b355036c8061e3282388826ec5
Author:     Olof Johansson <[EMAIL PROTECTED]>
AuthorDate: Wed Nov 28 20:58:06 2007 -0600
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Jan 28 15:04:26 2008 -0800

    pasemi_mac: Print warning when not attaching to a PHY
    pasemi_mac: Print warning when not attaching to a PHY
    Print a warning on the console when not connecting to a phy for an 
    It turns out to be a pretty common problem when someone gets the MDIO info
    wrong in their device tree, resulting in the macs running at a fixed 1Gbit 
    Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
    Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
 drivers/net/pasemi_mac.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index 07475bb..7345a81 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -1064,11 +1064,12 @@ static int pasemi_mac_open(struct net_device *dev)
        write_mac_reg(mac, PAS_MAC_CFG_PCFG, flags);
        ret = pasemi_mac_phy_init(dev);
-       /* Some configs don't have PHYs (XAUI etc), so don't complain about
-        * failed init due to -ENODEV.
+       /* Warn for missing PHY on SGMII (1Gig) ports.
-       if (ret && ret != -ENODEV)
-               dev_warn(&mac->pdev->dev, "phy init failed: %d\n", ret);
+       if (ret && mac->type == MAC_TYPE_GMAC) {
+               dev_warn(&mac->pdev->dev, "PHY init failed: %d.\n", ret);
+               dev_warn(&mac->pdev->dev, "Defaulting to 1Gbit full duplex\n");
+       }
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to