Commit:     ea40b324d791d86a42b858d073007de4d133227e
Parent:     8afd351c772d1815347d5c46716b099fde00a579
Author:     Pavel Emelyanov <[EMAIL PROTECTED]>
AuthorDate: Sun Dec 16 13:30:07 2007 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Jan 28 14:58:09 2008 -0800

    [IPV4]: Make __devinet_sysctl_register return an error
    Currently, this function is void, so failures in creating
    sysctls for new/renamed devices are not reported to anywhere.
    Fixing this is another complex (needed?) task, but this
    return value is needed during the namespaces creation to
    handle the case, when we failed to create "all" and "default"
    Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/ipv4/devinet.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 2dc2f7e..82def2c 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1454,8 +1454,8 @@ static struct devinet_sysctl_table {
-static void __devinet_sysctl_register(char *dev_name, int ctl_name,
-               struct ipv4_devconf *p)
+static int __devinet_sysctl_register(struct net *net, char *dev_name,
+               int ctl_name, struct ipv4_devconf *p)
        int i;
        struct devinet_sysctl_table *t;
@@ -1497,14 +1497,14 @@ static void __devinet_sysctl_register(char *dev_name, 
int ctl_name,
                goto free_procname;
        p->sysctl = t;
-       return;
+       return 0;
-       return;
+       return -ENOBUFS;
 static void __devinet_sysctl_unregister(struct ipv4_devconf *cnf)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to