Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dbf9d7da33f79302fb1e4d7c6b2f6598e8608e72
Commit:     dbf9d7da33f79302fb1e4d7c6b2f6598e8608e72
Parent:     ce40733ce93de402ed629762f0e912d9af187cef
Author:     Dmitry Monakhov <[EMAIL PROTECTED]>
AuthorDate: Mon Jan 28 23:58:27 2008 -0500
Committer:  Theodore Ts'o <[EMAIL PROTECTED]>
CommitDate: Mon Jan 28 23:58:27 2008 -0500

    ext4: fix uniniatilized extent splitting error
    
    Fix bug reported by Dmitry Monakhov caused by lost error code
    
        Testcase:
    
        blksize = 0x1000;
        fd = open(argv[1], O_RDWR|O_CREAT, 0700);
        unsigned long long sz = 0x10000000UL;
        /* allocating big blocks chunk */
        syscall(__NR_fallocate, fd, 0, 0UL, sz)
    
        /* grab all other available filesystem space */
        tfd = open("tmp", O_RDWR|O_CREAT|O_DIRECT, 0700);
        while( write(tfd, buf, 4096) > 0); /* loop untill ENOSPC */
        fsync(fd); /* just in case */
        while (pos < sz) {
                /* each seek+ write operation result in splits uninitialized 
extent
                in three extents. Splitting may result in new extent allocation
                which probably will fail because of ENOSPC*/
    
                lseek(fd, blksize*2 -1, SEEK_CUR);
                if ((ret = write(fd, 'a', 1)) != 1)
                        exit(1);
                pos += blksize * 2;
        }
    
    Signed-off-by: Dmitry Monakhov <[EMAIL PROTECTED]>
    Signed-off-by: Mingming Cao <[EMAIL PROTECTED]>
    Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]>
---
 fs/ext4/extents.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0cffb59..ce9aa58 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2373,9 +2373,10 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode 
*inode,
                        ret = ext4_ext_convert_to_initialized(handle, inode,
                                                                path, iblock,
                                                                max_blocks);
-                       if (ret <= 0)
+                       if (ret <= 0) {
+                               err = ret;
                                goto out2;
-                       else
+                       } else
                                allocated = ret;
                        goto outnew;
                }
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to