Commit:     3de5489f47febe0333b142e0eb6389b9924b2634
Parent:     a47c51044a77124ce66cd8513bba6f4d7673e43d
Author:     Gerrit Renker <[EMAIL PROTECTED]>
AuthorDate: Sat Nov 24 20:37:48 2007 -0200
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Mon Jan 28 14:54:51 2008 -0800

    [CCID2]: Bug in reading Ack Vectors
    In CCID2 the receiver-history is sorted in ascending order of sequence 
    but the processing of received Ack Vectors requires the list traversal in 
    opposite direction.
    The current code has a bug in this regard: the list traversal is upwards. 
As a
    consequence, only Ack Vectors with a run length of 1 will pass, in all other
    Ack Vectors the remaining (acked) sequence numbers are missed, and may later
    falsely be identified as lost.
    Note: This bug is only visible when Ack Ratio > 1, since otherwise the run
          lengths of Ack Vectors are 0.
    Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
    Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
    Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
 net/dccp/ccids/ccid2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c
index c9c465e..7873dc7 100644
--- a/net/dccp/ccids/ccid2.c
+++ b/net/dccp/ccids/ccid2.c
@@ -666,7 +666,7 @@ static void ccid2_hc_tx_packet_recv(struct sock *sk, struct 
sk_buff *skb)
                                        done = 1;
-                               seqp = seqp->ccid2s_next;
+                               seqp = seqp->ccid2s_prev;
                        if (done)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to