Commit:     3d1c550874bcaf0d9b7fb66f601caed109074f4b
Parent:     f3c391e89c92651105364c6645244118ec9b3952
Author:     J. Bruce Fields <[EMAIL PROTECTED]>
AuthorDate: Tue Jan 15 16:43:19 2008 -0500
Committer:  Trond Myklebust <[EMAIL PROTECTED]>
CommitDate: Wed Jan 30 02:06:10 2008 -0500

    nfs4: allow nfsv4 acls on non-regular-files
    The rfc doesn't give any reason it shouldn't be possible to set an
    attribute on a non-regular file.  And if the server supports it, then it
    shouldn't be up to us to prevent it.
    Thanks to Erez for the report and Trond for further analysis.
    Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
    Tested-by: Erez Zadok <[EMAIL PROTECTED]>
    Signed-off-by: Trond Myklebust <[EMAIL PROTECTED]>
 fs/nfs/nfs4proc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index b3d4e8e..89efbcd 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3617,10 +3617,6 @@ int nfs4_setxattr(struct dentry *dentry, const char 
*key, const void *buf,
        if (strcmp(key, XATTR_NAME_NFSV4_ACL) != 0)
                return -EOPNOTSUPP;
-       if (!S_ISREG(inode->i_mode) &&
-           (!S_ISDIR(inode->i_mode) || inode->i_mode & S_ISVTX))
-               return -EPERM;
        return nfs4_proc_set_acl(inode, buf, buflen);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to