Commit:     8c4385d7f5b77415156c9b900016cc8161d49f17
Parent:     1c69524c2e5b83e52a098ebdeb4a8b52169f6a03
Author:     Adrian Bunk <[EMAIL PROTECTED]>
AuthorDate: Wed Jan 30 13:30:39 2008 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Wed Jan 30 13:30:39 2008 +0100

    x86: remove -maccumulate-outgoing-args on 32-bit
    Contrary to the comment "newer gccs do it by default", newer gcc versions
    default to -maccumulate-outgoing-args only with 
    and then only with some CPU settings.
    Measured with an i386 defconfig, gcc 4.2.1 and kernel 2.6.23-rc1 ("orig" is
    the plain kernel, "changed is with -maccumulate-outgoing-args removed):
    $ ls -la vmlinux*
    -rwxrwxr-x 1 bunk bunk 6269713 2007-07-24 22:19 vmlinux.changed
    -rwxrwxr-x 1 bunk bunk 6425361 2007-07-24 22:19 vmlinux.orig
    $ size vmlinux.*
       text    data     bss     dec     hex filename
    4493465  504108  614400 5611973  55a1c5 vmlinux.changed
    4646160  504108  614400 5764668  57f63c vmlinux.orig
    That's a 2.5% size increase that does for sure hurt small systems.
    If the stack unwinder ever comes back and needs this as indicated in the
    comment, adding it to the cflags when the user enabled the unwinder should 
    a better option.
    [ tglx: arch/x86 adaptation ]
    Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
    Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
 arch/x86/Makefile_32 |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/Makefile_32 b/arch/x86/Makefile_32
index f806cec..b152db7 100644
--- a/arch/x86/Makefile_32
+++ b/arch/x86/Makefile_32
@@ -48,10 +48,6 @@ include $(srctree)/arch/x86/Makefile_32.cpu
 # temporary until string.h is fixed
 cflags-y += -ffreestanding
-# this works around some issues with generating unwind tables in older gccs
-# newer gccs do it by default
-cflags-y += -maccumulate-outgoing-args
 # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
 # a lot more stack due to the lack of sharing of stacklots:
 KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then echo $(call 
cc-option,-fno-unit-at-a-time); fi ;)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to