Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9a1b62fe858ba6780a9aeb4ab5f7751038a6c15d
Commit:     9a1b62fe858ba6780a9aeb4ab5f7751038a6c15d
Parent:     53391fa20cab6df6b476a5a0ad6be653c9de0c46
Author:     Minoru Usui <[EMAIL PROTECTED]>
AuthorDate: Wed Jan 30 13:33:35 2008 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Wed Jan 30 13:33:35 2008 +0100

    x86: fix NUMA emulation on 64-bit
    
    I found a small bug of NUMA emulation code for x86_64. (CONFIG_NUMA_EMU)
    If machine is non-NUMA, find_node_by_addr() should return
    NUMA_NO_NODE, but current implementation code returns existent maximum
    NUMA node number + 1.
    This is not existent NUMA node number.
    
    However, this behaviour does not affect NUMA emulation fortunately, because
    acpi_fake_nodes() that is caller of find_node_by_addr() gets pxm
    (proximity domain) by node_to_pxm() from non-existent NUMA node number
    that was returned by find_node_by_addr().
    node_to_pxm() returns PXM_INVAL that means illegal or non-existent
    NUMA node number.
    
    Signed-off-by: Minoru Usui <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
    Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
---
 arch/x86/mm/srat_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c
index 4aed38f..37308d6 100644
--- a/arch/x86/mm/srat_64.c
+++ b/arch/x86/mm/srat_64.c
@@ -416,7 +416,7 @@ static int __init find_node_by_addr(unsigned long addr)
                        break;
                }
        }
-       return i;
+       return ret;
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to