Commit:     1a2b441231ddc12b785940000320894bfa02bd82
Parent:     934d15854d04e8ca2495d8f5698164df990d5d66
Author:     Andi Kleen <[EMAIL PROTECTED]>
AuthorDate: Wed Jan 30 13:33:54 2008 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Wed Jan 30 13:33:54 2008 +0100

    x86: fix early_ioremap() on 64-bit
    Fix early_ioremap() on x86-64
    I had ACPI failures on several machines since a few days. Symptom
    was NUMA nodes not getting detected or worse cores not getting detected.
    They all came from ACPI not being able to read various of its tables. I 
    bisected it down to Jeremy's "put _PAGE_GLOBAL into PAGE_KERNEL" change.
    With that the fix was fairly obvious. The problem was that early_ioremap()
    didn't use a "_all" flush that would affect the global PTEs too. So
    with global bits getting used everywhere now an early_ioremap would
    not actually flush a mapping if something else was mapped previously
    on that slot (which can happen with early_iounmap inbetween)
    This patch changes all flushes in init_64.c to be __flush_tlb_all()
    and fixes the problem here.
    Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
    Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
 arch/x86/mm/init_64.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 0fd9d7f..c250580 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -228,7 +228,7 @@ __meminit void *early_ioremap(unsigned long addr, unsigned 
long size)
                addr &= PMD_MASK;
                for (i = 0; i < pmds; i++, addr += PMD_SIZE)
                        set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
-               __flush_tlb();
+               __flush_tlb_all();
                return (void *)vaddr;
@@ -249,7 +249,7 @@ __meminit void early_iounmap(void *addr, unsigned long size)
        pmd = level2_kernel_pgt + pmd_index(vaddr);
        for (i = 0; i < pmds; i++)
                pmd_clear(pmd + i);
-       __flush_tlb();
+       __flush_tlb_all();
 static void __meminit
@@ -317,7 +317,7 @@ static void __meminit phys_pud_init(pud_t *pud_page, 
unsigned long addr, unsigne
-       __flush_tlb();
+       __flush_tlb_all();
 static void __init find_early_table_space(unsigned long end)
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to