Commit:     6c6199c1551b7acd4f7898f073b40ae565d3b834
Parent:     9ac71d00398674aaec664f30559f0a21d963862f
Author:     Li Zefan <[EMAIL PROTECTED]>
AuthorDate: Thu Dec 6 20:33:14 2007 +1100
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Thu Dec 20 17:13:34 2007 +1100

    [POWERPC] Don't cast a struct pointer to list_head pointer
    The casting is safe only when the list_head member is the first member
    of the structure, and even then it is better to use the address of the
    list_head structure member.
    Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
 arch/ppc/syslib/ocp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c
index 3f5be2c..d42d408 100644
--- a/arch/ppc/syslib/ocp.c
+++ b/arch/ppc/syslib/ocp.c
@@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int 
function, int index)
        dev = __ocp_find_device(vendor, function, index);
-       list_del((struct list_head *)dev);
+       list_del(&dev->link);
        DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: 
%d)... done.\n", vendor, function, index));
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to