Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0e5c2185e1c6508894e1ee1a8e9bf79e009e427
Commit:     d0e5c2185e1c6508894e1ee1a8e9bf79e009e427
Parent:     eff56c92a15c3dbb1e55efea5251e28c0e5efb8b
Author:     Geert Uytterhoeven <[EMAIL PROTECTED]>
AuthorDate: Sat Jan 19 07:32:19 2008 +1100
Committer:  Paul Mackerras <[EMAIL PROTECTED]>
CommitDate: Fri Jan 25 22:52:52 2008 +1100

    [POWERPC] PS3: Checkpatch cleanups for drivers/ps3/ps3-vuart.c
    
    Cleanup coding errors in drivers/ps3/ps3-vuart.c as reported by
    checkpatch.
    
    Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
    Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
    Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]>
---
 drivers/ps3/ps3-vuart.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
index bb8d5b1..a3e4ea9 100644
--- a/drivers/ps3/ps3-vuart.c
+++ b/drivers/ps3/ps3-vuart.c
@@ -108,18 +108,18 @@ static struct ps3_vuart_port_priv *to_port_priv(
 struct ports_bmp {
        u64 status;
        u64 unused[3];
-} __attribute__ ((aligned (32)));
+} __attribute__((aligned(32)));
 
 #define dump_ports_bmp(_b) _dump_ports_bmp(_b, __func__, __LINE__)
 static void __maybe_unused _dump_ports_bmp(
-       const struct ports_bmp* bmp, const char* func, int line)
+       const struct ports_bmp *bmp, const char *func, int line)
 {
        pr_debug("%s:%d: ports_bmp: %016lxh\n", func, line, bmp->status);
 }
 
 #define dump_port_params(_b) _dump_port_params(_b, __func__, __LINE__)
 static void __maybe_unused _dump_port_params(unsigned int port_number,
-       const char* func, int line)
+       const char *func, int line)
 {
 #if defined(DEBUG)
        static const char *strings[] = {
@@ -363,7 +363,7 @@ int ps3_vuart_disable_interrupt_disconnect(struct 
ps3_system_bus_device *dev)
  */
 
 static int ps3_vuart_raw_write(struct ps3_system_bus_device *dev,
-       const void* buf, unsigned int bytes, unsigned long *bytes_written)
+       const void *buf, unsigned int bytes, unsigned long *bytes_written)
 {
        int result;
        struct ps3_vuart_port_priv *priv = to_port_priv(dev);
@@ -431,7 +431,7 @@ void ps3_vuart_clear_rx_bytes(struct ps3_system_bus_device 
*dev,
        int result;
        struct ps3_vuart_port_priv *priv = to_port_priv(dev);
        u64 bytes_waiting;
-       void* tmp;
+       void *tmp;
 
        result = ps3_vuart_get_rx_bytes_waiting(dev, &bytes_waiting);
 
@@ -526,9 +526,8 @@ int ps3_vuart_write(struct ps3_system_bus_device *dev, 
const void *buf,
 
        lb = kmalloc(sizeof(struct list_buffer) + bytes, GFP_KERNEL);
 
-       if (!lb) {
+       if (!lb)
                return -ENOMEM;
-       }
 
        memcpy(lb->data, buf, bytes);
        lb->head = lb->data;
@@ -926,9 +925,8 @@ static int ps3_vuart_bus_interrupt_get(void)
 
        BUG_ON(vuart_bus_priv.use_count > 2);
 
-       if (vuart_bus_priv.use_count != 1) {
+       if (vuart_bus_priv.use_count != 1)
                return 0;
-       }
 
        BUG_ON(vuart_bus_priv.bmp);
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to