Commit:     4b67d35504d005e94328558ee2c8f661a46aaaf4
Parent:     9af6d9562414568ecadf96aaef5b88e7e8b19821
Author:     Mark Brown <[EMAIL PROTECTED]>
AuthorDate: Thu Jan 10 14:41:46 2008 +0100
Committer:  Jaroslav Kysela <[EMAIL PROTECTED]>
CommitDate: Thu Jan 31 17:29:51 2008 +0100

    [ALSA] soc - Don't lock the codec list in snd_soc_dapm_new_widgets()
    snd_soc_dapm_new_widgets() takes the codec lock when adding new widgets,
    causing lockdep warnings when applications later call down through ALSA
    to adjust controls.  Since widgets are only added during probe this lock
    should be unneeded so don't take it.
    Thanks to Dmitry Baryshkov <[EMAIL PROTECTED]> for reporting this issue.
    Cc: Dmitry Baryshkov <[EMAIL PROTECTED]>
    Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
    Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]>
    Signed-off-by: Jaroslav Kysela <[EMAIL PROTECTED]>
 sound/soc/soc-dapm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 8b61db2..620d7ea 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -971,7 +971,6 @@ int snd_soc_dapm_new_widgets(struct snd_soc_codec *codec)
        struct snd_soc_dapm_widget *w;
-       mutex_lock(&codec->mutex);
        list_for_each_entry(w, &codec->dapm_widgets, list)
                if (w->new)
@@ -1006,7 +1005,6 @@ int snd_soc_dapm_new_widgets(struct snd_soc_codec *codec)
        dapm_power_widgets(codec, SND_SOC_DAPM_STREAM_NOP);
-       mutex_unlock(&codec->mutex);
        return 0;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to