Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c72258c7c9de448d5ea826ec6b4737eccbaa6718
Commit:     c72258c7c9de448d5ea826ec6b4737eccbaa6718
Parent:     69e97c028b25ef10018d513ead6e7caad276e19f
Author:     Sam Ravnborg <[EMAIL PROTECTED]>
AuthorDate: Fri Feb 1 17:49:42 2008 +0100
Committer:  Ingo Molnar <[EMAIL PROTECTED]>
CommitDate: Fri Feb 1 17:49:42 2008 +0100

    x86: fix section mismatch warnings when referencing notifiers
    
    Fix the following warnings:
    WARNING: arch/x86/kernel/built-in.o(.exit.text+0xf8): Section mismatch in 
reference from the function msr_exit() to the variable 
.cpuinit.data:msr_class_cpu_notifier
    WARNING: arch/x86/kernel/built-in.o(.exit.text+0x158): Section mismatch in 
reference from the function cpuid_exit() to the variable 
.cpuinit.data:cpuid_class_cpu_notifier
    WARNING: arch/x86/kernel/built-in.o(.exit.text+0x171): Section mismatch in 
reference from the function microcode_exit() to the variable 
.cpuinit.data:mc_cpu_notifier
    
    In all three cases there were a function annotated __exit
    that referenced a variable annotated __cpuinitdata.
    
    The fix was to replace the annotation of the notifier
    with __refdata to tell modpost that the reference to
    a _cpuinit function in the notifier are OK.
    The unregister call that references the notifier
    variable will simple delete the function pointer
    so there is no problem ignoring the reference.
    
    Note: This looks like another case where __cpuinit
    has been used as replacement for proper use
    of CONFIG_HOTPLUG_CPU to decide what code are used for
    HOTPLUG_CPU.
    
    Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
    Cc: "H. Peter Anvin" <[EMAIL PROTECTED]>
    Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
 arch/x86/kernel/cpuid.c     |    2 +-
 arch/x86/kernel/microcode.c |    2 +-
 arch/x86/kernel/msr.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c
index dec66e4..a63432d 100644
--- a/arch/x86/kernel/cpuid.c
+++ b/arch/x86/kernel/cpuid.c
@@ -170,7 +170,7 @@ static int __cpuinit cpuid_class_cpu_callback(struct 
notifier_block *nfb,
        return err ? NOTIFY_BAD : NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata cpuid_class_cpu_notifier =
+static struct notifier_block __refdata cpuid_class_cpu_notifier =
 {
        .notifier_call = cpuid_class_cpu_callback,
 };
diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index 6ff447f..f2702d0 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -797,7 +797,7 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long 
action, void *hcpu)
        return NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata mc_cpu_notifier = {
+static struct notifier_block __refdata mc_cpu_notifier = {
        .notifier_call = mc_cpu_callback,
 };
 
diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index 21f6e3c..bd82850 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -168,7 +168,7 @@ static int __cpuinit msr_class_cpu_callback(struct 
notifier_block *nfb,
        return err ? NOTIFY_BAD : NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata msr_class_cpu_notifier = {
+static struct notifier_block __refdata msr_class_cpu_notifier = {
        .notifier_call = msr_class_cpu_callback,
 };
 
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to