Commit:     44a6995b32eb9b021ee71b279edb84728c9f5160
Parent:     38a417cc993f4535548e47207f9894e7c27e05e4
Author:     Tom Tucker <[EMAIL PROTECTED]>
AuthorDate: Sun Dec 30 21:07:38 2007 -0600
Committer:  J. Bruce Fields <[EMAIL PROTECTED]>
CommitDate: Fri Feb 1 16:42:09 2008 -0500

    svc: Remove unnecessary call to svc_sock_enqueue
    The svc_tcp_accept function calls svc_sock_enqueue after setting the
    SK_CONN bit. This doesn't actually do anything because the SK_BUSY bit
    is still set. The call is unnecessary anyway because the generic code in
    svc_recv calls svc_sock_received after calling the accept function.
    Signed-off-by: Tom Tucker <[EMAIL PROTECTED]>
    Acked-by: Neil Brown <[EMAIL PROTECTED]>
    Reviewed-by: Chuck Lever <[EMAIL PROTECTED]>
    Reviewed-by: Greg Banks <[EMAIL PROTECTED]>
    Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
 net/sunrpc/svcsock.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 41d1f81..962dbf4 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1064,7 +1064,6 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt 
        set_bit(SK_CONN, &svsk->sk_flags);
-       svc_sock_enqueue(svsk);
        err = kernel_getpeername(newsock, sin, &slen);
        if (err < 0) {
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to