Commit:     a96ca105a68bc66c564accdfeb81c36e1d5d46b3
Parent:     e3236a1173222ca209d20bb29f6c1cd3499aa845
Author:     Jesper Juhl <[EMAIL PROTECTED]>
AuthorDate: Mon Dec 17 09:47:17 2007 +1000
Committer:  Dave Airlie <[EMAIL PROTECTED]>
CommitDate: Thu Feb 7 15:09:39 2008 +1000

    mga_dma: return 'err' not just zero from mga_do_cleanup_dma()
    While reading some code I stumbled across the use of 'err' in
    drivers/char/drm/mga_dma.c::mga_do_cleanup_dma() and I think there's a small
    The variable is only used inside #if __OS_HAS_AGP which is fine, but all 
    ever happens is an assignment to the variable - it is never actually used 
    anything.  The variable is nicely initialized to zero which is also what the
    return statement at the end of function returns (always at the moment).
    It looks to me like that function should be returning 'err' instead of 
    just returning 0.  Here's a patch to do that.
    Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Dave Airlie <[EMAIL PROTECTED]>
 drivers/char/drm/mga_dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/drm/mga_dma.c b/drivers/char/drm/mga_dma.c
index 04998b7..9d95f60 100644
--- a/drivers/char/drm/mga_dma.c
+++ b/drivers/char/drm/mga_dma.c
@@ -998,7 +998,7 @@ static int mga_do_cleanup_dma(struct drm_device *dev, int 
-       return 0;
+       return err;
 int mga_dma_init(struct drm_device *dev, void *data,
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to