Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=435bc9dfc6927eed9465e297d7aca1217aa61956
Commit:     435bc9dfc6927eed9465e297d7aca1217aa61956
Parent:     a219994bf5cca1208fb741b20ea9eb78e1711f81
Author:     Ursula Braun <[EMAIL PROTECTED]>
AuthorDate: Thu Feb 7 18:06:52 2008 -0800
Committer:  David S. Miller <[EMAIL PROTECTED]>
CommitDate: Thu Feb 7 18:06:52 2008 -0800

    [IUCV]: wrong irq-disabling locking at module load time
    
    Linux may hang when running af_iucv socket programs concurrently
    with a load of module netiucv. iucv_register() tries to take the
    iucv_table_lock with spin_lock_irq. This conflicts with
    iucv_connect() which has a need for an smp_call_function while
    holding the iucv_table_lock.
    Solution: use bh-disabling locking in iucv_register()
    
    Signed-off-by: Ursula Braun <[EMAIL PROTECTED]>
    Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
---
 net/iucv/iucv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
index f13fe88..2753b0c 100644
--- a/net/iucv/iucv.c
+++ b/net/iucv/iucv.c
@@ -693,9 +693,9 @@ int iucv_register(struct iucv_handler *handler, int smp)
                iucv_setmask_up();
        INIT_LIST_HEAD(&handler->paths);
 
-       spin_lock_irq(&iucv_table_lock);
+       spin_lock_bh(&iucv_table_lock);
        list_add_tail(&handler->list, &iucv_handler_list);
-       spin_unlock_irq(&iucv_table_lock);
+       spin_unlock_bh(&iucv_table_lock);
        rc = 0;
 out_mutex:
        mutex_unlock(&iucv_register_mutex);
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to