Commit:     c958d767dc79250583902a382275961b5da91a4d
Parent:     e390bc0a26ba522f008a1f9479097f1c6fc0189c
Author:     James Bottomley <[EMAIL PROTECTED]>
AuthorDate: Mon Feb 11 16:18:55 2008 -0600
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Tue Feb 12 15:24:58 2008 -0600

    [SCSI] sym53c416: fix module parameters
    It looks like there's been a bug in the module parameter setup forever.
    The upshot doesn't really matter, because even if no parameters are ever
    set, we just call sym53c416_setup() three times, but the zero values in
    the arrays eventually cause nothing to happen.  Unfortunately gcc has
    started to notice this now too:
    drivers/scsi/sym53c416.c: In function 'sym53c416_detect':
    drivers/scsi/sym53c416.c:624: warning: the address of 'sym53c416' will 
always evaluate as 'true'
    drivers/scsi/sym53c416.c:630: warning: the address of 'sym53c416_1' will 
always evaluate as 'true'
    drivers/scsi/sym53c416.c:636: warning: the address of 'sym53c416_2' will 
always evaluate as 'true'
    drivers/scsi/sym53c416.c:642: warning: the address of 'sym53c416_3' will 
always evaluate as 'true'
    So fix this longstanding bug to keep gcc quiet.
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/sym53c416.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c
index 6325901..f7d2795 100644
--- a/drivers/scsi/sym53c416.c
+++ b/drivers/scsi/sym53c416.c
@@ -187,10 +187,10 @@
 #define sym53c416_base_2 sym53c416_2
 #define sym53c416_base_3 sym53c416_3
-static unsigned int sym53c416_base[2] = {0,0};
-static unsigned int sym53c416_base_1[2] = {0,0};
-static unsigned int sym53c416_base_2[2] = {0,0};
-static unsigned int sym53c416_base_3[2] = {0,0};
+static unsigned int sym53c416_base[2];
+static unsigned int sym53c416_base_1[2];
+static unsigned int sym53c416_base_2[2];
+static unsigned int sym53c416_base_3[2];
@@ -621,25 +621,25 @@ int __init sym53c416_detect(struct scsi_host_template 
        int ints[3];
        ints[0] = 2;
-       if(sym53c416_base)
+       if(sym53c416_base[0])
                ints[1] = sym53c416_base[0];
                ints[2] = sym53c416_base[1];
                sym53c416_setup(NULL, ints);
-       if(sym53c416_base_1)
+       if(sym53c416_base_1[0])
                ints[1] = sym53c416_base_1[0];
                ints[2] = sym53c416_base_1[1];
                sym53c416_setup(NULL, ints);
-       if(sym53c416_base_2)
+       if(sym53c416_base_2[0])
                ints[1] = sym53c416_base_2[0];
                ints[2] = sym53c416_base_2[1];
                sym53c416_setup(NULL, ints);
-       if(sym53c416_base_3)
+       if(sym53c416_base_3[0])
                ints[1] = sym53c416_base_3[0];
                ints[2] = sym53c416_base_3[1];
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to