Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e03f1a842287480aa03732612148c0d333baca61
Commit:     e03f1a842287480aa03732612148c0d333baca61
Parent:     ae5e1b6cc511b278ad52b2d42afb44780e5d4cb2
Author:     Adrian Bunk <[EMAIL PROTECTED]>
AuthorDate: Tue Feb 19 19:44:19 2008 +0000
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Tue Feb 19 15:52:27 2008 -0800

    dm-raid1.c: fix NULL dereferences
    
    This patch fixes two NULL dereferences introduced by commit
    06386bbfd2441416875d0403d405c56822f6ebac and spotted by the Coverity
    checker.
    
    Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
    Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 drivers/md/dm-raid1.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index 2928ef2..5160587 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -1695,14 +1695,15 @@ static int mirror_end_io(struct dm_target *ti, struct 
bio *bio,
                         * information for a retry or there was no other
                         * mirror in-sync.
                         */
-                       DMERR_LIMIT("Mirror read failed from %s.",
-                                   m->dev->name);
+                       DMERR_LIMIT("Mirror read failed.");
                        return -EIO;
                }
+
+               m = read_record->m;
+
                DMERR("Mirror read failed from %s. Trying alternative device.",
                      m->dev->name);
 
-               m = read_record->m;
                fail_mirror(m, DM_RAID1_READ_ERROR);
 
                /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to