Commit:     c9872fe1add5709fffd42249e6ca1080999aa06a
Parent:     26106e3ca379e30790c41d8835e79395437152ec
Author:     FUJITA Tomonori <[EMAIL PROTECTED]>
AuthorDate: Fri Feb 22 23:11:04 2008 +0900
Committer:  James Bottomley <[EMAIL PROTECTED]>
CommitDate: Fri Feb 22 17:20:59 2008 -0600

    [SCSI] stex: stex_internal_copy should be called with sg_count in struct 
    stex_internal_copy copies an in-kernel buffer to a sg list by using
    scsi_kmap_atomic_sg. Some functions calls stex_internal_copy with
    sg_count in struct st_ccb, which is the value that dma_map_sg
    returned. However it might be shorter than the actual number of sg
    entries (if the IOMMU merged the sg entries).
    scsi_kmap_atomic_sg doesn't see sg->dma_length so stex_internal_copy
    should be called with the actual number of sg entries
    (i.e. scsi_sg_count), because if the sg entries were merged,
    stex_direct_copy wrongly think that the data length in the sg list is
    shorter than the actual length.
    Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
    Acked-by: Ed Lin <[EMAIL PROTECTED]>
    Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
 drivers/scsi/stex.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 4b6861c..654430e 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -467,7 +467,8 @@ static void stex_controller_info(struct st_hba *hba, struct 
st_ccb *ccb)
        size_t count = sizeof(struct st_frame);
        p = hba->copy_buffer;
-       stex_internal_copy(ccb->cmd, p, &count, ccb->sg_count, ST_FROM_CMD);
+       stex_internal_copy(ccb->cmd, p, &count, scsi_sg_count(ccb->cmd),
+                          ST_FROM_CMD);
        memset(p->base, 0, sizeof(u32)*6);
        *(unsigned long *)(p->base) = pci_resource_start(hba->pdev, 0);
        p->rom_addr = 0;
@@ -485,7 +486,8 @@ static void stex_controller_info(struct st_hba *hba, struct 
st_ccb *ccb)
        p->subid =
                hba->pdev->subsystem_vendor << 16 | hba->pdev->subsystem_device;
-       stex_internal_copy(ccb->cmd, p, &count, ccb->sg_count, ST_TO_CMD);
+       stex_internal_copy(ccb->cmd, p, &count, scsi_sg_count(ccb->cmd),
+                          ST_TO_CMD);
 static void
@@ -699,7 +701,7 @@ static void stex_copy_data(struct st_ccb *ccb,
        if (ccb->cmd == NULL)
-               resp->variable, &count, ccb->sg_count, ST_TO_CMD);
+               resp->variable, &count, scsi_sg_count(ccb->cmd), ST_TO_CMD);
 static void stex_ys_commands(struct st_hba *hba,
@@ -724,7 +726,7 @@ static void stex_ys_commands(struct st_hba *hba,
                count = STEX_EXTRA_SIZE;
                stex_internal_copy(ccb->cmd, hba->copy_buffer,
-                       &count, ccb->sg_count, ST_FROM_CMD);
+                       &count, scsi_sg_count(ccb->cmd), ST_FROM_CMD);
                inq_data = (ST_INQ *)hba->copy_buffer;
                if (inq_data->DeviceTypeQualifier != 0)
                        ccb->srb_status = SRB_STATUS_SELECTION_TIMEOUT;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to