Commit:     eaeb16883bd6aa2d6b6b61b825c0d2b0dc793f60
Parent:     de4fc64f0f2a4efbaad3e7c1e1e05a28f69b45e5
Author:     David Rientjes <[EMAIL PROTECTED]>
AuthorDate: Sat Feb 23 15:23:34 2008 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Sat Feb 23 17:12:14 2008 -0800

    sparc: fix build
    Fix build failure on sparc:
        In file included from include/linux/mm.h:39,
                        from include/linux/memcontrol.h:24,
                        from include/linux/swap.h:8,
                        from include/linux/suspend.h:7,
                        from init/do_mounts.c:6:
        include/asm/pgtable.h:344: warning: parameter names (without
                types) in function declaration
        include/asm/pgtable.h:345: warning: parameter names (without
                types) in function declaration
        include/asm/pgtable.h:346: error: expected '=', ',', ';', 'asm' or
                '__attribute__' before '___f___swp_entry'
    viro sayeth:
      I've run allmodconfig builds on a bunch of target, FWIW (essentially the
      same patch).  Note that these includes are recent addition caused by added
      inline function that had since then become a define.  So while I agree 
      your comments in general, in _this_ case it's pretty safe.
      The commit that had done it is 3062fc67dad01b1d2a15d58c709eff946389eca4
      ("memcontrol: move mm_cgroup to header file") and the switch to #define
      is in commit 60c12b1202a60eabb1c61317e5d2678fcea9893f ("memcontrol: add
      vm_match_cgroup()") (BTW, that probably warranted mentioning in the
      changelog of the latter).
    Cc: Adrian Bunk <[EMAIL PROTECTED]>
    Cc: Robert Reif <[EMAIL PROTECTED]>
    Signed-off-by: David Rientjes <[EMAIL PROTECTED]>
    Cc: "David S. Miller" <[EMAIL PROTECTED]>
    Cc: Al Viro <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
 include/linux/memcontrol.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 925d57b..0407562 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -20,9 +20,6 @@
-#include <linux/rcupdate.h>
-#include <linux/mm.h>
 struct mem_cgroup;
 struct page_cgroup;
 struct page;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to