> The change itself looks good; care to write it up as a proper patch
> with a proposed log message?

I'm working on writing a proper patch, but I'm running into a
problem.  The patch itself is from this commit:

    $ git log -1
    commit 07a25537909dd277426818a39d9bc4235e755383
    Author: Dale Worley <wor...@ariadne.com>
    Date:   Thu Jul 18 18:43:12 2013 -0400

        open() returns -1 on failure, and indeed 0 is a possible success value
        if the user closed stdin in our process.  Fix the test.
    $ 

But the output of "git format-patch" is:

    From 07a25537909dd277426818a39d9bc4235e755383 Mon Sep 17 00:00:00 2001
    From: Dale Worley <wor...@ariadne.com>
    Date: Thu, 18 Jul 2013 18:43:12 -0400
    Subject: [PATCH] open() returns -1 on failure, and indeed 0 is a possible
     success value if the user closed stdin in our process.  Fix
     the test.

    ---
     t/t0070-fundamental.sh |    7 +++++++
     wrapper.c              |    2 +-
     2 files changed, 8 insertions(+), 1 deletions(-)

    diff --git a/t/t0070-fundamental.sh b/t/t0070-fundamental.sh
    index 986b2a8..d427f3a 100755
    --- a/t/t0070-fundamental.sh
    +++ b/t/t0070-fundamental.sh
    @@ -25,6 +25,13 @@ test_expect_success POSIXPERM,SANITY 'mktemp to 
unwritable directory prints file
            grep "cannotwrite/test" err
    [...]

Notice that the whole commit message has been formatted as if it is
part of the Subject line, and the line breaks in the commit message
have been refilled.

The file Documentation/SubmittingPatches says that "git format-patch"
produces patches in the best format, but the manual page shows an
example more like this:

    From 8f72bad1baf19a53459661343e21d6491c3908d3 Mon Sep 17 00:00:00 2001
    From: Tony Luck <tony.l...@intel.com>
    Date: Tue, 13 Jul 2010 11:42:54 -0700
    Subject: [PATCH] Put ia64 config files on the
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit

    arch/arm config files were slimmed down using a python script
    (See commit c2330e286f68f1c408b4aa6515ba49d57f05beae comment)
    [...]

That is, the first line of the commit message is in the Subject and
the remaining lines are in the message body.  As far as I can tell,
that's what SubmittingPatches prescribes.  And that is what I see in
the Git mailing list on vger.

(All of this is with git 1.7.7.6.)

Exactly how should the commit message be inserted into the patch
e-mail?

Dale

-- 
You received this message because you are subscribed to the Google Groups "Git 
for human beings" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to git-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to