The menu is defijned at ~line  2329

The match function check is ~line 4878

https://github.com/git/git/blob/master/gitk-git/gitk#L4878

It looks like it was coded to do as you ask, but that some update to the tcl itself (maybe i18n, or utf8 capabilities) has caused the `-nocase` check to fail.

my reading of https://www.tcl.tk/man/tcl8.0/TclCmd/string.htm suggests there is no `-nocase` option in that version.

https://wiki.tcl.tk/4385 https://www.tcl.tk/man/tcl8.5/TclCmd/string.htm give more for that version. needs close reading.

----- Original Message ----- From: "Philip Oakley" <philipoak...@iee.org>
To: <git-users@googlegroups.com>
Sent: Wednesday, June 13, 2018 10:05 PM
Subject: Re: [git-users] (Bug report) gitk "IgnCase" search doesn't work


Hi Juan,

I think it will be option 3....
Have a dive into the tcl code (it's not that hard once you realise it's just code), search for the bit that does the IgnCase and see if you can spot what should have been done (at least where the issue may be).

The git list will be interested and supportive of a researched bug report with pointer to the are to be fixed.

Have a look at "https://public-inbox.org/git/?q="; or https://public-inbox.org/git/ and search for either gitk or 'git gui' to see the recent contributors in that area (and their solutions).

The current issue with gitk / git gui is that there isn't an active maintainer for those parts of the eco-system, so the uptake by Git and GfW can be sporadic.

Philip

----- Original Message ----- From: "Juan Navarro" <juan.nava...@gmx.es>
To: "Git for human beings" <git-users@googlegroups.com>
Sent: Monday, June 11, 2018 4:04 PM
Subject: [git-users] (Bug report) gitk "IgnCase" search doesn't work


I'm genuinely surprised that this doesn't seem to have been reported, but I swear I did my homework searching in Google, in this users list, and in the
Git Community Mailing List, without relevant results. So, here it goes.

Gitk "find commit" search function doesn't follow the "IgnCase" option that
is selectable with a combo selector on the right side of the window; it
should be searching in a case-insensitive way, but it doesn't.

Steps to reproduce:
1. Clone any repo. I'm right now using
https://github.com/Kurento/kms-core.git
2. cd into the repo and launch gitk
3. In the "Find commit" bar, select "changing lines matching"
4. In the right side of the same bar, select "IgnCase"
5. Search for a term that you know exists in uppercase, but write the
search in lowercase. In my example, I'm searching for "leaky_time".
6. No search results appear.
7. Change your search word to uppercase.
8. Some search results appear, thus proving that the search is being done
case-sensitive.

The only direct mention of this issue that I was able to find was this
answer that seems to confirm that this is a bug, but doesn't help much:
https://stackoverflow.com/questions/11964704/msysgit-how-do-i-use-gitk-to-search-for-string-in-commit-ignoring-case

Should I follow steps from https://git-scm.com/community and write a bug
report directly to the Git mailing list? Or maybe this is well known and
the solution is hidden somewhere here?

--
You received this message because you are subscribed to the Google Groups "Git for human beings" group. To unsubscribe from this group and stop receiving emails from it, send an email to git-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
You received this message because you are subscribed to the Google Groups "Git for 
human beings" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to git-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to