tasn pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2da13de20aff0f3f849589440302c0f2ec0a0ddf

commit 2da13de20aff0f3f849589440302c0f2ec0a0ddf
Author: Tom Hacohen <t...@stosb.com>
Date:   Mon Apr 13 13:50:43 2015 +0100

    Evas object: verify the parent is valid and fail if not.
    
    It seems like before the switch to Eo, all the object_*_add functions
    had magic checks that only allowed non NULL Evas pointers to be passed.
    Since we switched to Eo we apparently missed the early failure we used
    to have, and we instead fail later. This patch should fix that.
    
    Thanks to jaehwan for reporting.
    
    @fix
---
 src/lib/evas/canvas/evas_object_main.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/evas_object_main.c 
b/src/lib/evas/canvas/evas_object_main.c
index 3c0c8d5..d25a460 100644
--- a/src/lib/evas/canvas/evas_object_main.c
+++ b/src/lib/evas/canvas/evas_object_main.c
@@ -85,11 +85,15 @@ _init_cow(void)
 EOLIAN static void
 _evas_object_eo_base_constructor(Eo *eo_obj, Evas_Object_Protected_Data *obj)
 {
+   Eo *parent = NULL;
+
    eo_do_super(eo_obj, MY_CLASS, eo_constructor());
    eo_do(eo_obj, evas_obj_type_set(MY_CLASS_NAME));
    eo_manual_free_set(eo_obj, EINA_TRUE);
 
-   if (!obj || !_init_cow())
+   eo_do(eo_obj, parent = eo_parent_get());
+
+   if (!obj || !_init_cow() || !eo_isa(parent, 
EVAS_COMMON_INTERFACE_INTERFACE))
      {
         eo_error_set(eo_obj);
         return;

-- 


Reply via email to