hermet pushed a commit to branch master.


commit 96c6cda2c5e803b70cf75c985337c457e383737c
Author: Woochan Lee <wc0917....@samsung.com>
Date:   Fri Apr 24 16:27:15 2015 +0900

    spinner: Fix entry not inactive even gets an enter key cb.
     The entry inactive signal emitted when finish spinner value set.
    but the active signal emitted after that. so it makes weird view state.
     The function 'key_action_toggle()' called twice. (for entry, spinner)
    event propagate called this func twice and its make this issue.
    This patch makes to ignore toggle event when entry is not visible.
    Test Plan:
    Run elementary_test, execute spinner widget sample.
    Click the first spinner.
    Input something on entry.
    Press enter key.
    Check the issue.
    Reviewers: raster, Hermet
    Subscribers: kuuko
    Differential Revision: https://phab.enlightenment.org/D2411
 src/lib/elm_spinner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c
index 90d602a..2262e77 100644
--- a/src/lib/elm_spinner.c
+++ b/src/lib/elm_spinner.c
@@ -456,7 +456,7 @@ _key_action_toggle(Evas_Object *obj, const char *params 
    ELM_SPINNER_DATA_GET(obj, sd);
    if (sd->spin_timer) _spin_stop(obj);
-   else _entry_toggle_cb(NULL, obj, NULL, NULL);
+   else if (sd->entry_visible) _entry_toggle_cb(NULL, obj, NULL, NULL);
    return EINA_FALSE;


Reply via email to