devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1d887a10056bdb80e5b6becdba20e0325f38712e

commit 1d887a10056bdb80e5b6becdba20e0325f38712e
Author: Derek Foreman <der...@osg.samsung.com>
Date:   Thu Apr 30 14:27:04 2015 -0400

    ecore_drm: close fd if flag set fails
    
    @fix
    
    Subscribers: cedric
    
    Differential Revision: https://phab.enlightenment.org/D2454
---
 src/lib/ecore_drm/ecore_drm_launcher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/ecore_drm/ecore_drm_launcher.c 
b/src/lib/ecore_drm/ecore_drm_launcher.c
index e66918a..ae28be0 100644
--- a/src/lib/ecore_drm/ecore_drm_launcher.c
+++ b/src/lib/ecore_drm/ecore_drm_launcher.c
@@ -140,8 +140,10 @@ _ecore_drm_launcher_device_open_no_pending(const char 
*device, int flags)
    if (logind)
      {
         fd = _ecore_drm_logind_device_open_no_pending(device);
-        if ((fd = _ecore_drm_launcher_device_flags_set(fd, flags)) < 0)
+        if (fd < 0) return -1;
+        if (_ecore_drm_launcher_device_flags_set(fd, flags) < 0)
           {
+             close(fd);
              _ecore_drm_logind_device_close(device);
              return -1;
           }

-- 


Reply via email to