hermet pushed a commit to branch master.


commit 1cda2d76d8db1c083379ab83493942b0aa09a28e
Author: Andrii Kroitor <an.kroi...@samsung.com>
Date:   Fri Aug 28 20:18:23 2015 +0900

    elm_genlist: fix sub-items prepending
    fix sub-item position after prepending if parent item has no other
    Test Plan:
    1. add genlist
    2. add parent item
    3. compare results of following actions:
     case 1: append sub-item "child1" and then prepend sub-item "child2"
     case 2: prepend sub-item "child2" and then append sub-item "child1"
    ExR results are the same
    CuR in case 2 sub-items are placed in wrong position
    Reviewers: cedric, raster, reutskiy.v.v, SanghyeonLee, Hermet
    Reviewed By: Hermet
    Differential Revision: https://phab.enlightenment.org/D2965
 src/lib/elm_genlist.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index c27f429..687040f 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -6112,6 +6112,9 @@ _elm_genlist_item_prepend(Eo *obj EINA_UNUSED, 
Elm_Genlist_Data *sd, const Elm_G
         ELM_GENLIST_ITEM_DATA_GET(eo_parent, parent);
         EINA_SAFETY_ON_FALSE_RETURN_VAL((obj == WIDGET(parent)), NULL);
+        /* first sub-item should allways be appended */
+        if (!parent->item->items)
+          return _elm_genlist_item_append(obj, sd, itc, data, eo_parent, type, 
func, func_data);
    it = _elm_genlist_item_new


Reply via email to