cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ce4ef2cf91144df407614cfe91c113625865922d

commit ce4ef2cf91144df407614cfe91c113625865922d
Author: Vincent Torri <vincent dot torri at gmail dot com>
Date:   Tue Sep 29 23:47:10 2015 +0200

    ecore_exe: close handles only if they are valid
    
    Signed-off-by: Cedric BAIL <ced...@osg.samsung.com>
---
 src/lib/ecore/ecore_exe_win32.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/ecore/ecore_exe_win32.c b/src/lib/ecore/ecore_exe_win32.c
index 73957d7..d488d5a 100644
--- a/src/lib/ecore/ecore_exe_win32.c
+++ b/src/lib/ecore/ecore_exe_win32.c
@@ -382,8 +382,8 @@ _impl_ecore_exe_eo_base_finalize(Eo *obj, Ecore_Exe_Data 
*exe)
    SECURITY_ATTRIBUTES sa;
    STARTUPINFO si;
    PROCESS_INFORMATION pi;
-   HANDLE child_pipe_read;
-   HANDLE child_pipe_error;
+   HANDLE child_pipe_read = NULL;
+   HANDLE child_pipe_error = NULL;
    const char *shell = NULL;
    Ecore_Exe_Event_Add *e;
    Ecore_Exe_Flags flags;
@@ -504,8 +504,8 @@ _impl_ecore_exe_eo_base_finalize(Eo *obj, Ecore_Exe_Data 
*exe)
     * the pipe will not close when the child process exits and the
     * ReadFile will hang.
     */
-   CloseHandle(child_pipe_read);
-   CloseHandle(child_pipe_error);
+   IF_FN_DEL(CloseHandle, child_pipe_read);
+   IF_FN_DEL(CloseHandle, child_pipe_error);
 
    /* be sure that the child process is running */
    /* FIXME: This does not work if the child is an EFL-based app */

-- 


Reply via email to