devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e04146f7dec24fa1769519b57fc996a1ddd33af5

commit e04146f7dec24fa1769519b57fc996a1ddd33af5
Author: Chris Michael <cp.mich...@samsung.com>
Date:   Tue Nov 17 10:06:55 2015 -0500

    ector: Fix incorrect expression
    
    Coverity reports that 'obj' is written twice with the same value
    here., so fix this with a proper call to eo_do_super_ret
    
    NB: Fixes Coverity CID1339786
    
    @fix
    
    Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
 src/lib/ector/cairo/ector_renderer_cairo_shape.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/ector/cairo/ector_renderer_cairo_shape.c 
b/src/lib/ector/cairo/ector_renderer_cairo_shape.c
index 5f6f1b4..2672be5 100644
--- a/src/lib/ector/cairo/ector_renderer_cairo_shape.c
+++ b/src/lib/ector/cairo/ector_renderer_cairo_shape.c
@@ -259,7 +259,7 @@ _ector_renderer_cairo_shape_eo_base_constructor(Eo *obj, 
Ector_Renderer_Cairo_Sh
    USE(obj, cairo_path_destroy, NULL);
    USE(obj, cairo_move_to, NULL);
 
-   obj = eo_do_super_ret(obj, ECTOR_RENDERER_CAIRO_SHAPE_CLASS, obj, obj = 
eo_constructor());
+   obj = eo_do_super_ret(obj, ECTOR_RENDERER_CAIRO_SHAPE_CLASS, obj, 
eo_constructor());
    if (!obj) return NULL;
 
    pd->shape = eo_data_xref(obj, ECTOR_RENDERER_GENERIC_SHAPE_MIXIN, obj);

-- 


Reply via email to