tasn pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3896c03cffc85d08767a5dad6c13c14e34d20a7f

commit 3896c03cffc85d08767a5dad6c13c14e34d20a7f
Author: Tom Hacohen <t...@stosb.com>
Date:   Tue Dec 8 11:35:25 2015 +0000

    Evas render2: Fix always false comparisons.
    
    This looks like a classic copy and paste error. It didn't make any sense
    before, and it seems like no one was going to take a look at it.
    This looks correct. If this breaks something (is render2 even used),
    someone should remove those lines. I wasn't entirely sure if I should
    just remove them, or correct them, as some of the code looked redundant
    anyway.
---
 src/lib/evas/canvas/render2/region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/evas/canvas/render2/region.c 
b/src/lib/evas/canvas/render2/region.c
index 2958b89..c2d095e 100644
--- a/src/lib/evas/canvas/render2/region.c
+++ b/src/lib/evas/canvas/render2/region.c
@@ -853,14 +853,14 @@ region_add(Region *dest, Region *source)
    if (PIXREGION_NIL(source))
      {
         if (PIXREGION_NAR(source)) return _region_break(dest);
-        if (dest != dest) return region_copy(dest, dest);
+        if (dest != source) return region_copy(dest, source);
         return EINA_TRUE;
      }
 
    // Region 1 completely subsumes region 2
    if (!dest->data && CONTAINS(&dest->bound, &source->bound))
      {
-        if (dest != dest) return region_copy(dest, dest);
+        if (dest != source) return region_copy(dest, source);
         return EINA_TRUE;
      }
 

-- 


Reply via email to