kuuko pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=caef23bb34d2183c8d9ee611a086713f084f7ed6
commit caef23bb34d2183c8d9ee611a086713f084f7ed6
Author: Kai Huuhko <kai.huu...@gmail.com>
Date: Tue Feb 2 14:11:33 2016 +0200
Trivial todo note updates and doc fix
---
TODO | 1 +
efl/edje/efl.edje_edit_program.pxi | 2 +-
efl/elementary/fileselector.pxi | 6 +++---
efl/elementary/gengrid_item.pxi | 4 ++--
efl/elementary/gengrid_widget.pxi | 2 +-
efl/elementary/genlist_widget.pxi | 5 ++---
efl/elementary/map.pxi | 1 -
efl/elementary/multibuttonentry.pxi | 6 ++++--
efl/elementary/notify.pxi | 2 +-
efl/elementary/object.pxi | 5 ++---
efl/elementary/transit.pxi | 11 ++++++-----
efl/elementary/web.pxi | 2 +-
efl/eo/efl.eo.pyx | 2 +-
efl/evas/efl.evas_object_image.pxi | 2 +-
efl/utils/conversions.pyx | 2 +-
include/efl.evas.pxd | 12 ++++++------
16 files changed, 33 insertions(+), 32 deletions(-)
diff --git a/TODO b/TODO
index 4e41a98..3a1396e 100644
--- a/TODO
+++ b/TODO
@@ -11,6 +11,7 @@ BUGS
- Multibuttonentry.filter_append()
- Multibuttonentry.filterprepend()
... maybe do like is done in genlist filter_set() ??
+* API break in
https://git.enlightenment.org/bindings/python/python-efl.git/commit/efl/elementary/label.pyx?id=9be98bb979917932cc2850a54f6e79281c871401
, find out if it had users anywhere, remove if not
Failing unit tests
------------------
diff --git a/efl/edje/efl.edje_edit_program.pxi
b/efl/edje/efl.edje_edit_program.pxi
index 32479de..e6b3161 100644
--- a/efl/edje/efl.edje_edit_program.pxi
+++ b/efl/edje/efl.edje_edit_program.pxi
@@ -50,7 +50,7 @@ cdef class Program(object):
def run(self):
return bool(edje_edit_program_run(self.edje.obj, self.name))
- # XXX TODO: add (or better convert) all this to properties
+ # TODO: add (or better convert) all this to properties
# like is done in Part()
def source_get(self):
cdef const char *s
diff --git a/efl/elementary/fileselector.pxi b/efl/elementary/fileselector.pxi
index 80ea7f6..a861bfb 100644
--- a/efl/elementary/fileselector.pxi
+++ b/efl/elementary/fileselector.pxi
@@ -351,8 +351,8 @@ cdef class Fileselector(LayoutClass):
"""
cb_data = (func, data)
- # TODO: This is now a ref leak. It should be stored somewhere and
- # deleted in the remove method.
+ # FIXME: This is now a ref leak. It should be stored somewhere and
+ # deleted in the remove method.
Py_INCREF(cb_data)
if isinstance(filter_name, unicode): filter_name =
PyUnicode_AsUTF8String(filter_name)
@@ -443,7 +443,7 @@ cdef class Fileselector(LayoutClass):
self._callback_del_full("selected", _cb_string_conv, func)
#
- # FIXME: This seems to be a thing that the application should handle
+ # TODO: This seems to be a thing that the application should handle
#
#def callback_selected_invalid_add(self, func, *args, **kwargs):
#"""The user has tried to access a path which does not exist."""
diff --git a/efl/elementary/gengrid_item.pxi b/efl/elementary/gengrid_item.pxi
index ce4b8f4..4c7cda5 100644
--- a/efl/elementary/gengrid_item.pxi
+++ b/efl/elementary/gengrid_item.pxi
@@ -298,9 +298,9 @@ cdef class GengridItem(ObjectItem):
elm_gengrid_item_pos_get(self.item, &x, &y)
return (x, y)
- # XXX TODO elm_gengrid_item_item_class_update
+ # TODO: elm_gengrid_item_item_class_update
- # XXX TODO elm_gengrid_item_item_class_get
+ # TODO: elm_gengrid_item_item_class_get
property select_mode:
"""Item's select mode. Possible values are:
diff --git a/efl/elementary/gengrid_widget.pxi
b/efl/elementary/gengrid_widget.pxi
index 58e7a54..81ad765 100644
--- a/efl/elementary/gengrid_widget.pxi
+++ b/efl/elementary/gengrid_widget.pxi
@@ -210,7 +210,7 @@ cdef class Gengrid(Object):
return GengridItem(item_class, item_data, func, item_data)\
.insert_before(after_item)
- # XXX TODO elm_gengrid_item_sorted_insert()
+ # TODO: elm_gengrid_item_sorted_insert()
property selected_item:
"""This returns the selected item. If multi selection is enabled
diff --git a/efl/elementary/genlist_widget.pxi
b/efl/elementary/genlist_widget.pxi
index b558f4a..98e28b0 100644
--- a/efl/elementary/genlist_widget.pxi
+++ b/efl/elementary/genlist_widget.pxi
@@ -256,7 +256,6 @@ cdef class Genlist(Object):
ObjectItem parent_item=None,
int flags=ELM_GENLIST_ITEM_NONE,
func=None
- #API XXX: *args, **kwargs
):
"""This inserts a new item in the genlist based on a user defined
comparison function.
@@ -356,8 +355,8 @@ cdef class Genlist(Object):
"""
def __get__(self):
return
_object_item_list_to_python(elm_genlist_realized_items_get(self.obj))
- # XXX: Free the list? We could return a custom list-like object
here
- # that frees the C list in its __dealloc__
+ # FIXME: Free the list! We could return a custom list-like object
here
+ # that frees the C list in its __dealloc__
def realized_items_get(self):
return
_object_item_list_to_python(elm_genlist_realized_items_get(self.obj))
diff --git a/efl/elementary/map.pxi b/efl/elementary/map.pxi
index 26dadd3..8f0c89f 100644
--- a/efl/elementary/map.pxi
+++ b/efl/elementary/map.pxi
@@ -164,7 +164,6 @@ cdef class MapName(object):
<const char *>address if address is not None else NULL,
lon, lat, _map_name_callback, <void *>data)
Py_INCREF(data)
- # XXX: why incref self in __init__?
Py_INCREF(self)
def delete(self):
diff --git a/efl/elementary/multibuttonentry.pxi
b/efl/elementary/multibuttonentry.pxi
index e1bfbf3..aa874bc 100644
--- a/efl/elementary/multibuttonentry.pxi
+++ b/efl/elementary/multibuttonentry.pxi
@@ -44,7 +44,7 @@ cdef char * _multibuttonentry_format_cb(int count, void
*data) with gil:
traceback.print_exc()
return NULL
- # TODO leak here
+ # FIXME: leak here
return strdup(<char *>s)
@@ -378,6 +378,7 @@ cdef class MultiButtonEntry(Object):
elm_multibuttonentry_item_filter_append(self.obj,
_multibuttonentry_filter_callback, <void *>cbdata)
+ # FIXME: leak here
Py_INCREF(cbdata)
def filter_prepend(self, func, *args, **kwargs):
@@ -386,6 +387,7 @@ cdef class MultiButtonEntry(Object):
elm_multibuttonentry_item_filter_prepend(self.obj,
_multibuttonentry_filter_callback, <void *>cbdata)
+ # FIXME: leak here
Py_INCREF(cbdata)
#TODO
@@ -433,7 +435,7 @@ cdef class MultiButtonEntry(Object):
elm_multibuttonentry_format_function_set(self.obj,
_multibuttonentry_format_cb,
<void *>cbdata)
- # TODO leak here
+ # FIXME: leak here
Py_INCREF(cbdata)
def callback_item_selected_add(self, func, *args, **kwargs):
diff --git a/efl/elementary/notify.pxi b/efl/elementary/notify.pxi
index 1d9d798..24f9463 100644
--- a/efl/elementary/notify.pxi
+++ b/efl/elementary/notify.pxi
@@ -17,7 +17,7 @@
include "notify_cdef.pxi"
-# FIXME: cdef extern this
+# TODO: move this to cdefs
ELM_NOTIFY_ALIGN_FILL = -1.0
cdef class Notify(Object):
diff --git a/efl/elementary/object.pxi b/efl/elementary/object.pxi
index fd8cb36..c229e2e 100644
--- a/efl/elementary/object.pxi
+++ b/efl/elementary/object.pxi
@@ -38,7 +38,6 @@ cdef void _tooltip_data_del_cb(void *data, Evas_Object *o,
void *event_info) wit
cdef bint _event_dispatcher(Object obj, Object src, Evas_Callback_Type t,
event_info):
cdef bint ret
- # XXX: This is expensive code
for func, args, kargs in obj._elm_event_cbs:
try:
ret = func(obj, src, t, event_info, *args, **kargs)
@@ -478,7 +477,7 @@ cdef class Object(SmartObject):
signal_callback)
#
- # FIXME: Review this
+ # TODO: Review this
#
# NOTE: name clash with evas event_callback_*
def elm_event_callback_add(self, func, *args, **kargs):
@@ -1871,5 +1870,5 @@ cdef class Object(SmartObject):
# """
# elm_access_highlight_set(self.obj)
-# TODO: Check if this is used correctly here
+# FIXME: Check if this is used correctly here
_object_mapping_register("Elm_Widget", Object)
diff --git a/efl/elementary/transit.pxi b/efl/elementary/transit.pxi
index 4eb40ed..d1d5c6a 100644
--- a/efl/elementary/transit.pxi
+++ b/efl/elementary/transit.pxi
@@ -141,16 +141,17 @@ cdef class Transit(object):
"""
elm_transit_del(self.obj)
- # TODO: Fix the documentation
def effect_add(self, TransitCustomEffect effect):
"""Add a new effect to the transit.
Example::
+ class MyEffect(TransitCustomEffect):
+ # define your methods...
+
t = Transit()
- t.effect_add( elm_transit_effect_blend_op,
- elm_transit_effect_blend_context_new(),
- elm_transit_effect_blend_context_free)
+ e = MyEffect()
+ t.effect_add(e)
.. warning:: The transit will free the context data at the and of the
transition with the data_free_cb function. Do not share the
@@ -160,7 +161,7 @@ cdef class Transit(object):
you try to add an existing effect, nothing is done.
.. note:: After the first addition of an effect to ``transit``, if its
effect list become empty again, the ``transit`` will be killed by
- elm_transit_del(transit) function.
+ :meth:`delete` function.
:param effect: The context data of the effect.
diff --git a/efl/elementary/web.pxi b/efl/elementary/web.pxi
index b9ee90d..f67a5bc 100644
--- a/efl/elementary/web.pxi
+++ b/efl/elementary/web.pxi
@@ -928,7 +928,7 @@ cdef class Web(Object):
# """Queries if the menubar is visible. Event info
# is a bool where the callback should set True if
# the menubar is visible, or False in case it's not."""
- # # XXX: the cb for this should use the return value, not the bool
passed.
+ # # FIXME: the cb for this should use the return value, not the bool
passed.
# self._callback_add_full("menubar,visible,get", _cb_bool_conv, func,
# *args, **kwargs)
diff --git a/efl/eo/efl.eo.pyx b/efl/eo/efl.eo.pyx
index 13cf9df..391c4a7 100644
--- a/efl/eo/efl.eo.pyx
+++ b/efl/eo/efl.eo.pyx
@@ -175,7 +175,7 @@ cdef void _register_decorated_callbacks(Eo obj):
cdef object attr_name, attrib, func_name, func
cdef type cls = type(obj)
- # XXX: This whole thing is really slow. Can we do it better?
+ # FIXME: This whole thing is really slow. Can we do it better?
for attr_name, attrib in cls.__dict__.items():
if "__decorated_callbacks__" in dir(attrib):
diff --git a/efl/evas/efl.evas_object_image.pxi
b/efl/evas/efl.evas_object_image.pxi
index 9594747..48e8a3e 100644
--- a/efl/evas/efl.evas_object_image.pxi
+++ b/efl/evas/efl.evas_object_image.pxi
@@ -1384,7 +1384,7 @@ cdef class FilledImage(Image):
raise NotImplementedError("FilledImage doesn't support fill_set()")
-#TODO: Check if this is right
+#FIXME: Check if this is right
_object_mapping_register("Evas_FilledImage", FilledImage)
def extension_can_load(filename):
diff --git a/efl/utils/conversions.pyx b/efl/utils/conversions.pyx
index 3c1cc76..a602bf6 100644
--- a/efl/utils/conversions.pyx
+++ b/efl/utils/conversions.pyx
@@ -72,7 +72,7 @@ cdef const char **
python_list_strings_to_array_of_strings(list strings) except
unsigned int str_len, i
unsigned int arr_len = len(strings)
- # TODO: Should we just return NULL in this case?
+ # FIXME: Should we just return NULL in this case?
if arr_len == 0:
array = <const char **>malloc(sizeof(const char*))
if not array:
diff --git a/include/efl.evas.pxd b/include/efl.evas.pxd
index 1d78d72..c2b2ae0 100644
--- a/include/efl.evas.pxd
+++ b/include/efl.evas.pxd
@@ -866,7 +866,7 @@ cdef extern from "Evas.h":
Evas_Object *evas_object_image_add(Evas *e)
# TODO: Use this?: Evas_Object *evas_object_image_filled_add(Evas
*e)
# TODO: void evas_object_image_memfile_set(Evas_Object
*obj, void *data, int size, char *format, char *key)
- # FIXME: Is this needed?: const Eo_Class *evas_object_image_class_get()
+ # TODO: Is this needed?: const Eo_Class *evas_object_image_class_get()
void evas_object_image_file_set(Evas_Object *obj, const
char *file, const char *key)
void evas_object_image_file_get(const Evas_Object *obj,
const char **file, const char **key)
void evas_object_image_border_set(Evas_Object *obj, int l,
int r, int t, int b)
@@ -1051,7 +1051,7 @@ cdef extern from "Evas.h":
#
Evas_Object *evas_object_box_add(Evas *e)
Evas_Object *evas_object_box_add_to(Evas_Object *parent)
- # FIXME: Is this needed?: const Eo_Class *evas_object_box_class_get()
+ # TODO: Is this needed?: const Eo_Class *evas_object_box_class_get()
void evas_object_box_align_set(Evas_Object *o, double horizontal, double
vertical)
void evas_object_box_align_get(const Evas_Object *o, double *horizontal,
double *vertical)
@@ -1174,8 +1174,8 @@ cdef extern from "Evas.h":
Eina_Bool evas_object_table_unpack(Evas_Object
*o, Evas_Object *child)
void evas_object_table_clear(Evas_Object *o,
Eina_Bool clear)
void
evas_object_table_col_row_size_get(const Evas_Object *o, int *cols, int *rows)
- # FIXME: Not needed?: Eina_Iterator
*evas_object_table_iterator_new(const Evas_Object *o)
- # FIXME: Not needed?: Eina_Accessor
*evas_object_table_accessor_new(const Evas_Object *o)
+ # TODO: Not needed?: Eina_Iterator
*evas_object_table_iterator_new(const Evas_Object *o)
+ # TODO: Not needed?: Eina_Accessor
*evas_object_table_accessor_new(const Evas_Object *o)
Eina_List *evas_object_table_children_get(const
Evas_Object *o)
Evas_Object *evas_object_table_child_get(const
Evas_Object *o, unsigned short col, unsigned short row)
@@ -1192,8 +1192,8 @@ cdef extern from "Evas.h":
Eina_Bool evas_object_grid_unpack(Evas_Object *o, Evas_Object *child)
void evas_object_grid_clear(Evas_Object *o, Eina_Bool clear)
Eina_Bool evas_object_grid_pack_get(const Evas_Object *o, Evas_Object
*child, int *x, int *y, int *w, int *h)
- # FIXME: Is this needed? Eina_Iterator
*evas_object_grid_iterator_new(const Evas_Object *o)
- # FIXME: Is this needed? Eina_Accessor
*evas_object_grid_accessor_new(const Evas_Object *o)
+ # TODO: Is this needed? Eina_Iterator *evas_object_grid_iterator_new(const
Evas_Object *o)
+ # TODO: Is this needed? Eina_Accessor *evas_object_grid_accessor_new(const
Evas_Object *o)
Eina_List *evas_object_grid_children_get(const Evas_Object *o)
--
