jaehyun pushed a commit to branch master.

http://git.enlightenment.org/tools/enventor.git/commit/?id=3cb3dfdda78f0bc56a3f70d584ddfcd2c4081186

commit 3cb3dfdda78f0bc56a3f70d584ddfcd2c4081186
Author: taehyub <taehyub....@samsung.com>
Date:   Fri Mar 4 16:09:40 2016 +0900

    ctxpopup.c: change sprintf function to snprintf function
    
    Summary:
    change sprintf to snprintf for code safety
    
    @fix
    
    Reviewers: Hermet, Jaehyun_Cho, NikaWhite
    
    Differential Revision: https://phab.enlightenment.org/D3757
---
 src/lib/ctxpopup.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/lib/ctxpopup.c b/src/lib/ctxpopup.c
index 09bb3f8..eee963e 100644
--- a/src/lib/ctxpopup.c
+++ b/src/lib/ctxpopup.c
@@ -394,7 +394,8 @@ colorselector_changed_cb(void *data, Evas_Object *obj,
    evas_object_color_set(ctxdata->color_view, (r * a) / 255 , (g * a) / 255, 
(b * a) / 255, a);
 
    ecore_animator_del(ctxdata->animator);
-   sprintf(ctxdata->candidate, ": %d %d %d %d;", r, g, b, a);
+   snprintf(ctxdata->candidate, sizeof(ctxdata->candidate), ": %d %d %d %d;",
+            r, g, b, a);
    ctxdata->animator = ecore_animator_add(changed_animator_cb, ctxdata);
 
    preset_cur_color.r = r;
@@ -421,7 +422,8 @@ colorselector_inputs_changed_cb(void *data, Evas_Object 
*obj,
    elm_colorselector_color_set(ctxdata->colorselector, r, g, b, a);
 
    ecore_animator_del(ctxdata->animator);
-   sprintf(ctxdata->candidate, ": %d %d %d %d;", r, g, b, a);
+   snprintf(ctxdata->candidate, sizeof(ctxdata->candidate), ": %d %d %d %d;",
+            r, g, b, a);
    ctxdata->animator = ecore_animator_add(changed_animator_cb, ctxdata);
 
    preset_cur_color.r = r;
@@ -455,7 +457,8 @@ colorselector_preset_clicked_cb(void *data,  Evas *e 
EINA_UNUSED, Evas_Object *o
    elm_spinner_value_set(ctxdata->input_colors[3], a);
 
    ecore_animator_del(ctxdata->animator);
-   sprintf(ctxdata->candidate, ": %d %d %d %d;", r, g, b, a);
+   snprintf(ctxdata->candidate, sizeof(ctxdata->candidate), ": %d %d %d %d;",
+            r, g, b, a);
    ctxdata->animator = ecore_animator_add(changed_animator_cb, ctxdata);
 
    preset_cur_color.r = r;

-- 


Reply via email to