cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=bdde588b164ffbd23839a701cf789b94b05077bb

commit bdde588b164ffbd23839a701cf789b94b05077bb
Author: Jee-Yong Um <jc9...@samsung.com>
Date:   Tue Mar 15 11:39:47 2016 -0700

    edje: remove redundant fetch code in file.set method
    
    Summary:
    Edje data structure is passed as a parameter, but in file.set method
    _edje_fetch() is called one more time unnecessarily.
    
    Reviewers: cedric, jpeg
    
    Differential Revision: https://phab.enlightenment.org/D3788
    
    Signed-off-by: Cedric Bail <ced...@osg.samsung.com>
---
 src/lib/edje/edje_smart.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/lib/edje/edje_smart.c b/src/lib/edje/edje_smart.c
index ab42445..a8ef1bc 100644
--- a/src/lib/edje/edje_smart.c
+++ b/src/lib/edje/edje_smart.c
@@ -338,7 +338,7 @@ _edje_object_evas_object_smart_calculate(Eo *obj 
EINA_UNUSED, Edje *ed)
 }
 
 EOLIAN static Eina_Bool
-_edje_object_efl_file_file_set(Eo *obj, Edje *_pd EINA_UNUSED, const char 
*file, const char *group)
+_edje_object_efl_file_file_set(Eo *obj, Edje *ed, const char *file, const char 
*group)
 {
    Eina_Bool ret;
    Eina_File *f = NULL;
@@ -351,9 +351,6 @@ _edje_object_efl_file_file_set(Eo *obj, Edje *_pd 
EINA_UNUSED, const char *file,
         f = eina_file_open(file, EINA_FALSE);
         if (!f)
           {
-             Edje *ed;
-
-             ed = _edje_fetch(obj);
              ed->load_error = EDJE_LOAD_ERROR_DOES_NOT_EXIST;
              return ret;
           }

-- 


Reply via email to