cedric pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=7e801846e9c77328f42364f5b9aebe3d4b75b812
commit 7e801846e9c77328f42364f5b9aebe3d4b75b812 Author: Youngbok Shin <[email protected]> Date: Fri Mar 18 11:54:00 2016 -0700 modules: remove error message from dlsym() when a module is loaded Summary: dlsym() could print error message when it tried to load a nonexistent symbol. Whenever eina_module_load is called, it checks __eina_module_init symbol. Even if there is no symbol for init, module loading could be done well. But, it will print an error message. So, we need to use EINA_MODULE_INIT, EINA_MODULE_SHUTDOWN in every modules for removing error messages. Test Plan: N/A Reviewers: woohyun, raster, Hermet, seoz, cedric Reviewed By: cedric Differential Revision: https://phab.enlightenment.org/D3805 Signed-off-by: Cedric Bail <[email protected]> --- src/modules/access_output/mod.c | 14 ++++++++++++++ .../datetime_input_ctxpopup/datetime_input_ctxpopup.c | 14 ++++++++++++++ src/modules/test_entry/mod.c | 14 ++++++++++++++ 3 files changed, 42 insertions(+) diff --git a/src/modules/access_output/mod.c b/src/modules/access_output/mod.c index 3f15f32..0dff159 100644 --- a/src/modules/access_output/mod.c +++ b/src/modules/access_output/mod.c @@ -121,3 +121,17 @@ out_done_callback_set(void (*func) (void *data), const void *data) cb_func = func; cb_data = (void *)data; } + +static Eina_Bool +_module_init(void) +{ + return EINA_TRUE; +} + +static void +_module_shutdown(void) +{ +} + +EINA_MODULE_INIT(_module_init); +EINA_MODULE_SHUTDOWN(_module_shutdown); diff --git a/src/modules/datetime_input_ctxpopup/datetime_input_ctxpopup.c b/src/modules/datetime_input_ctxpopup/datetime_input_ctxpopup.c index b8dc56c..198f095 100644 --- a/src/modules/datetime_input_ctxpopup/datetime_input_ctxpopup.c +++ b/src/modules/datetime_input_ctxpopup/datetime_input_ctxpopup.c @@ -382,3 +382,17 @@ elm_modapi_shutdown(void *m EINA_UNUSED) { return 1; // succeed always } + +static Eina_Bool +_module_init(void) +{ + return EINA_TRUE; +} + +static void +_module_shutdown(void) +{ +} + +EINA_MODULE_INIT(_module_init); +EINA_MODULE_SHUTDOWN(_module_shutdown); diff --git a/src/modules/test_entry/mod.c b/src/modules/test_entry/mod.c index 025d9b4..d2d5171 100644 --- a/src/modules/test_entry/mod.c +++ b/src/modules/test_entry/mod.c @@ -35,3 +35,17 @@ obj_longpress(Evas_Object *obj) { printf("longpress: %p\n", obj); } + +static Eina_Bool +_module_init(void) +{ + return EINA_TRUE; +} + +static void +_module_shutdown(void) +{ +} + +EINA_MODULE_INIT(_module_init); +EINA_MODULE_SHUTDOWN(_module_shutdown); --
