[EGIT] [tools/eflete] master 08/23: property_group: fix behaviour on item selection/unselection

[Vitalii Vorobiov]

rimmed pushed a commit to branch master.

http://git.enlightenment.org/tools/eflete.git/commit/?id=2e2917e4b683c183ffb0d941e942c0080266981a

commit 2e2917e4b683c183ffb0d941e942c0080266981a
Author: Vitalii Vorobiov <vi.vorob...@samsung.com>
Date:   Tue Apr 19 20:35:58 2016 +0300

    property_group: fix behaviour on item selection/unselection
    
    Hide part before selecting item
    hide item when no item was selected
    
    Fixes T3480
---
 src/bin/ui/property_group.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/bin/ui/property_group.c b/src/bin/ui/property_group.c
index 8912b8d..97a0ce2 100644
--- a/src/bin/ui/property_group.c
+++ b/src/bin/ui/property_group.c
@@ -587,11 +587,8 @@ _on_part_selected(void *data,
    GROUP_PROP_DATA_GET()
    Part *part = event_info;
 
-   if (!part)
-     {
-        _ui_property_part_unset(property);
-        return;
-     }
+   _ui_property_part_unset(property);
+   if (!part) return;
    ui_property_part_set(property, part);
    ui_property_part_state_set(property, part);
    if (part->current_item_name)
@@ -4723,21 +4720,16 @@ _ui_property_part_item_set(Evas_Object *property, Part 
*part)
 static void
 _ui_property_part_item_unset(Evas_Object *property)
 {
-   Evas_Object *prop_box, *item_box;
+   Evas_Object *prop_box;
 
    GROUP_PROP_DATA_GET()
 
    if (!pd_item.frame) return;
 
-   pd->item_name = NULL;
    prop_box = elm_object_content_get(pd->scroller);
-   elm_box_unpack(prop_box, pd_item.frame);
-
-   item_box = elm_object_content_get(pd_item.frame);
-   elm_box_unpack(item_box, pd_item.position_item);
-
-   evas_object_hide(pd_item.frame);
-   evas_object_hide(pd_item.position_item);
+   PROP_ITEM_UNSET(prop_box, pd_item.frame)
+   PROP_ITEM_UNSET(prop_box, pd_item.position_item)
+   pd->item_name = NULL;
 }
 #undef pd_item
 

--