discomfitor pushed a commit to branch enlightenment-0.20.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=be742c4adca4d5f5aac17cb511f9002d1bd6130a
commit be742c4adca4d5f5aac17cb511f9002d1bd6130a
Author: Shuhrat Dehkanov <sh.dehka...@samsung.com>
Date: Mon Apr 18 12:00:20 2016 -0400
xkbswitch: establish parent/child relationship
Summary:
There is an edge case that results in SIGFAULT in Enlightenment when
"Keyboard Settings" dialog is closed prior to "Add New Configuration"
dialog and "OK" button is pressed in the latter one.
This makes sure that closing the dialogs follows the parent/child logic.
@fix
Test Plan:
1. Go to Settings -> All -> Input -> Keyboard and press "Add"
2. Observe that "Add New Configuration" dialog is opened
3. Select/highlight any new layout
4. Go back to "Keyboard Settings" dialog and close it
5. Press "OK" in "Keyboard Settings" dialog
6. Observe that Enlightenment sigfaults
Reviewers: zmike, raster
Subscribers: cedric, seoz
Differential Revision: https://phab.enlightenment.org/D3901
---
src/modules/xkbswitch/e_mod_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/modules/xkbswitch/e_mod_config.c
b/src/modules/xkbswitch/e_mod_config.c
index f0f0a4d..f400bc6 100644
--- a/src/modules/xkbswitch/e_mod_config.c
+++ b/src/modules/xkbswitch/e_mod_config.c
@@ -543,7 +543,7 @@ _dlg_add_new(E_Config_Dialog_Data *cfdata)
Evas_Coord mw, mh;
Evas_Object *mainn, *available, *modelss, *variants;
- if (!(dlg = e_dialog_new(NULL, "E", "xkbswitch_config_add_dialog"))) return
NULL;
+ if (!(dlg = e_dialog_new(e_win_evas_win_get(cfdata->evas), "E",
"xkbswitch_config_add_dialog"))) return NULL;
e_dialog_resizable_set(dlg, 1);
dlg->data = cfdata;
--
